Fix ODR violations caused by mojoms being included in multiple components.

Fix ODR violations caused by mojoms being included in multiple components.

This also changes the component //device/generic_sensor/public/cpp to
use a different export define to //device/generic_sensor.

BUG=636563
Committed: https://crrev.com/ca5c38a9bf976e082d873f2f3cd0cb0d923e9159
Cr-Commit-Position: refs/heads/master@{#439705}

[Sam McNally, 2016-12-19 05:59:01]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 05:59:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-19 06:52:17]

Description was changed from

==========
Fix some ODR violations due to mojoms being used by multiple components.
==========

to

==========
Fix ODR violations caused by mojoms being included in multiple components.

BUG=636563
==========

[Sam McNally, 2016-12-19 07:04:49]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 07:04:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-19 07:06:31]

Description was changed from

==========
Fix ODR violations caused by mojoms being included in multiple components.

BUG=636563
==========

to

==========
Fix ODR violations caused by mojoms being included in multiple components.

This also changes the component //device/generic_sensor/public/cpp to
use a different export define to //device/generic_sensor.

BUG=636563
==========

[commit-bot: I haz the power, 2016-12-19 08:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 08:30:53]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-19 08:56:11]

sammc@chromium.org changed reviewers:
+ reillyg@chromium.org, sashab@chromium.org

[Sam McNally, 2016-12-19 08:56:11]

+sashab for //third_party/WebKit/Source/core/offscreencanvas/BUILD.gn

+reillyg for //device

[Reilly Grant (use Gerrit), 2016-12-19 19:23:37]

lgtm

[sashab, 2016-12-19 23:23:43]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org

[sashab, 2016-12-19 23:23:44]

haraken@ ptal at third_party/WebKit/Source/core/offscreencanvas/BUILD.gn

https://codereview.chromium.org/2587883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/offscreencanvas/BUILD.gn (left):

https://codereview.chromium.org/2587883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/offscreencanvas/BUILD.gn:14:
"//third_party/WebKit/public:offscreen_canvas_mojo_bindings_blink",
What does this mean? Is this correct?

Not sure if we want things relying on Source/platform or exposed modules

Adding haraken@ for advice

[haraken, 2016-12-20 00:13:06]

https://codereview.chromium.org/2587883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/offscreencanvas/BUILD.gn (right):

https://codereview.chromium.org/2587883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/offscreencanvas/BUILD.gn:14:
"//third_party/WebKit/Source/platform",

core/ to platform/ should be already allowed. You won't need this.

[Sam McNally, 2016-12-20 00:27:56]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-12-20 00:28:21]

https://codereview.chromium.org/2587883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/offscreencanvas/BUILD.gn (right):

https://codereview.chromium.org/2587883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/offscreencanvas/BUILD.gn:14:
"//third_party/WebKit/Source/platform",
On 2016/12/20 00:13:06, haraken wrote:
> 
> core/ to platform/ should be already allowed. You won't need this.
> 

Done.

[commit-bot: I haz the power, 2016-12-20 00:28:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-12-20 00:32:01]

third_party/WebKit/Source/core/offscreencanvas/BUILD.gn LGTM :)

[haraken, 2016-12-20 00:32:57]

On 2016/12/20 00:32:01, sashab wrote:
> third_party/WebKit/Source/core/offscreencanvas/BUILD.gn LGTM :)

yes, LGTM :)

[Sam McNally, 2016-12-20 01:34:18]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-12-20 01:34:19]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2587883002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-12-20 01:34:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 04:28:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482197658628770,
"parent_rev": "76b49e63138c1535b97e310264999871e5dba0fd", "commit_rev":
"9605d463e66ca170b8337075304490dfbecce513"}

[commit-bot: I haz the power, 2016-12-20 04:30:15]

Description was changed from

==========
Fix ODR violations caused by mojoms being included in multiple components.

This also changes the component //device/generic_sensor/public/cpp to
use a different export define to //device/generic_sensor.

BUG=636563
==========

to

==========
Fix ODR violations caused by mojoms being included in multiple components.

This also changes the component //device/generic_sensor/public/cpp to
use a different export define to //device/generic_sensor.

BUG=636563

Review-Url: https://codereview.chromium.org/2587883002
==========

[commit-bot: I haz the power, 2016-12-20 04:30:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-20 04:32:23]

Description was changed from

==========
Fix ODR violations caused by mojoms being included in multiple components.

This also changes the component //device/generic_sensor/public/cpp to
use a different export define to //device/generic_sensor.

BUG=636563

Review-Url: https://codereview.chromium.org/2587883002
==========

to

==========
Fix ODR violations caused by mojoms being included in multiple components.

This also changes the component //device/generic_sensor/public/cpp to
use a different export define to //device/generic_sensor.

BUG=636563

Committed: https://crrev.com/ca5c38a9bf976e082d873f2f3cd0cb0d923e9159
Cr-Commit-Position: refs/heads/master@{#439705}
==========

[commit-bot: I haz the power, 2016-12-20 04:32:24]

Patchset 3 (id:??) landed as
https://crrev.com/ca5c38a9bf976e082d873f2f3cd0cb0d923e9159
Cr-Commit-Position: refs/heads/master@{#439705}