cros: Fix CrashRestoreComplexTest failure

cros: Fix CrashRestoreComplexTest failure

CrashRestoreComplexTest restores session for non-existent user.
The first session is created with browser_restart flag set. User
manager currently runs RegularUserLoggedInAsEphemeral for such
situation. This caused the first user not returned in UserManager's
GetUsers call and causes ProfileHelper::GetUserByProfile to return
nullptr. This CL fixes the case by using GetLoggedInUsers instead of
GetUsers in GetUserByProfile. This would not happen in production
where only known users could go through crash-n-restore path though.

BUG=648964
Committed: https://crrev.com/97cdab276ba8b839254e978a44d8f5ac79f0e322
Cr-Commit-Position: refs/heads/master@{#439632}

[xiyuan, 2016-12-19 20:33:35]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 20:34:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-12-19 20:39:25]

xiyuan@chromium.org changed reviewers:
+ alemate@chromium.org

[xiyuan, 2016-12-19 20:39:26]

Fix CrashRestoreComplexTest failure for CL
https://codereview.chromium.org/2573703003/.

The CL uses MultiUserWindowManagerChromeOS in tests. CrashRestoreComplexTest
fails because the MultiUserWindowManagerChromeOS is unable to get user1 from the
profile. This is because user1 is added on the commandline and goes through the
crash-n-restore code path. However, it is also a new user to UserManager. Thus
it is not part of the |users_| list. ProfileHelper::GetUserByProfile fails
because of that.

I don't have a clear plan on how to fix the UserManager for such case because
the situation would not happen in production (all crash-n-restore users should
be known there) and the code would be refactored soon. So I fix the problem in
GetUserByProfile.

Another possible fix would be change the tests to pre-populate local state and
make those users known.

Please take a look. Thanks.

[commit-bot: I haz the power, 2016-12-19 21:11:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:11:32]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-12-20 00:13:11]

lgtm

[xiyuan, 2016-12-20 00:17:50]

On 2016/12/20 00:13:11, Alexander Alekseev wrote:
> lgtm

Thanks.

[xiyuan, 2016-12-20 00:18:16]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2016-12-20 00:19:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 00:25:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482193096161400,
"parent_rev": "7d5fdc9fdca76662115831c1b526d6624c7a9e8c", "commit_rev":
"a84ac00504a0427be608c384e213c4a98d5c21f0"}

[commit-bot: I haz the power, 2016-12-20 00:26:12]

Description was changed from

==========
cros: Fix CrashRestoreComplexTest failure

CrashRestoreComplexTest restores session for non-existent user.
The first session is created with browser_restart flag set. User
manager currently runs RegularUserLoggedInAsEphemeral for such
situation. This caused the first user not returned in UserManager's
GetUsers call and causes ProfileHelper::GetUserByProfile to return
nullptr. This CL fixes the case by using GetLoggedInUsers instead of
GetUsers in GetUserByProfile. This would not happen in production
where only known users could go through crash-n-restore path though.

BUG=648964
==========

to

==========
cros: Fix CrashRestoreComplexTest failure

CrashRestoreComplexTest restores session for non-existent user.
The first session is created with browser_restart flag set. User
manager currently runs RegularUserLoggedInAsEphemeral for such
situation. This caused the first user not returned in UserManager's
GetUsers call and causes ProfileHelper::GetUserByProfile to return
nullptr. This CL fixes the case by using GetLoggedInUsers instead of
GetUsers in GetUserByProfile. This would not happen in production
where only known users could go through crash-n-restore path though.

BUG=648964

Review-Url: https://codereview.chromium.org/2587853003
==========

[commit-bot: I haz the power, 2016-12-20 00:26:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 00:27:58]

Description was changed from

==========
cros: Fix CrashRestoreComplexTest failure

CrashRestoreComplexTest restores session for non-existent user.
The first session is created with browser_restart flag set. User
manager currently runs RegularUserLoggedInAsEphemeral for such
situation. This caused the first user not returned in UserManager's
GetUsers call and causes ProfileHelper::GetUserByProfile to return
nullptr. This CL fixes the case by using GetLoggedInUsers instead of
GetUsers in GetUserByProfile. This would not happen in production
where only known users could go through crash-n-restore path though.

BUG=648964

Review-Url: https://codereview.chromium.org/2587853003
==========

to

==========
cros: Fix CrashRestoreComplexTest failure

CrashRestoreComplexTest restores session for non-existent user.
The first session is created with browser_restart flag set. User
manager currently runs RegularUserLoggedInAsEphemeral for such
situation. This caused the first user not returned in UserManager's
GetUsers call and causes ProfileHelper::GetUserByProfile to return
nullptr. This CL fixes the case by using GetLoggedInUsers instead of
GetUsers in GetUserByProfile. This would not happen in production
where only known users could go through crash-n-restore path though.

BUG=648964

Committed: https://crrev.com/97cdab276ba8b839254e978a44d8f5ac79f0e322
Cr-Commit-Position: refs/heads/master@{#439632}
==========

[commit-bot: I haz the power, 2016-12-20 00:27:59]

Patchset 2 (id:??) landed as
https://crrev.com/97cdab276ba8b839254e978a44d8f5ac79f0e322
Cr-Commit-Position: refs/heads/master@{#439632}