Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2587833002:
MacViews: Perform word lookup on force touch. (Closed)
|
Created:
4 years ago by karandeepb Modified:
4 years ago Reviewers:
tapted CC:
chromium-reviews, tfarina, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMacViews: Perform word lookup on force touch.
r368481 added support for force touch to the BaseView and r423419 implemented
dictionary lookup for views::Textfield on MacViews. This CL implements the
method forceTouchEvent: on the BridgedContentView. As a result, force touching
on a views::Textfield now performs dictionary lookup for the word under the
cursor as per the user's system preferences.
BUG=640502
TEST= Enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some
text in the name textfield. Force touch on one of the words in the text. Verify
that a dictionary popup appears showing the definition of the word under the
cursor.
Committed: https://crrev.com/8de9c34b9a48e07607bed42939e32ab2f4b79558
Cr-Commit-Position: refs/heads/master@{#439417}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address review. #Messages
Total messages: 15 (8 generated)
Description was changed from ========== Force touch. ========== to ========== MacViews: Perform word lookup on force touch. r368481 added support for force touch to the BaseView and r423419 implemented dictionary lookup for views::Textfield on MacViews. This CL implements the method forceTouchEvent: on the BridgedContentView. As a result, force touching on a views::Textfield now performs dictionary lookup for the word under the cursor. BUG=640502 TEST= Enable chrome://flags/#mac-views-native-dialogs. Open Bookmark Bubble. Enter some text in the name textfield. Force touch on one of the words in the text. Verify that a dictionary popup appears showing the definition of the word under the cursor. ==========
Description was changed from ========== MacViews: Perform word lookup on force touch. r368481 added support for force touch to the BaseView and r423419 implemented dictionary lookup for views::Textfield on MacViews. This CL implements the method forceTouchEvent: on the BridgedContentView. As a result, force touching on a views::Textfield now performs dictionary lookup for the word under the cursor. BUG=640502 TEST= Enable chrome://flags/#mac-views-native-dialogs. Open Bookmark Bubble. Enter some text in the name textfield. Force touch on one of the words in the text. Verify that a dictionary popup appears showing the definition of the word under the cursor. ========== to ========== MacViews: Perform word lookup on force touch. r368481 added support for force touch to the BaseView and r423419 implemented dictionary lookup for views::Textfield on MacViews. This CL implements the method forceTouchEvent: on the BridgedContentView. As a result, force touching on a views::Textfield now performs dictionary lookup for the word under the cursor. BUG=640502 TEST= Enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some text in the name textfield. Force touch on one of the words in the text. Verify that a dictionary popup appears showing the definition of the word under the cursor. ==========
karandeepb@chromium.org changed reviewers: + tapted@chromium.org
PTAL Trent.
https://codereview.chromium.org/2587833002/diff/1/ui/views/cocoa/bridged_cont... File ui/views/cocoa/bridged_content_view.mm (right): https://codereview.chromium.org/2587833002/diff/1/ui/views/cocoa/bridged_cont... ui/views/cocoa/bridged_content_view.mm:622: // Perform word lookup on force touch. The comment probably isn't necessary, but I think we need to have if (ui::ForceClickInvokesQuickLook()) since ForceTouch can be configured to do other things in System Prefs
Description was changed from ========== MacViews: Perform word lookup on force touch. r368481 added support for force touch to the BaseView and r423419 implemented dictionary lookup for views::Textfield on MacViews. This CL implements the method forceTouchEvent: on the BridgedContentView. As a result, force touching on a views::Textfield now performs dictionary lookup for the word under the cursor. BUG=640502 TEST= Enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some text in the name textfield. Force touch on one of the words in the text. Verify that a dictionary popup appears showing the definition of the word under the cursor. ========== to ========== MacViews: Perform word lookup on force touch. r368481 added support for force touch to the BaseView and r423419 implemented dictionary lookup for views::Textfield on MacViews. This CL implements the method forceTouchEvent: on the BridgedContentView. As a result, force touching on a views::Textfield now performs dictionary lookup for the word under the cursor as per the user's system preferences. BUG=640502 TEST= Enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some text in the name textfield. Force touch on one of the words in the text. Verify that a dictionary popup appears showing the definition of the word under the cursor. ==========
PTAL Trent. https://codereview.chromium.org/2587833002/diff/1/ui/views/cocoa/bridged_cont... File ui/views/cocoa/bridged_content_view.mm (right): https://codereview.chromium.org/2587833002/diff/1/ui/views/cocoa/bridged_cont... ui/views/cocoa/bridged_content_view.mm:622: // Perform word lookup on force touch. On 2016/12/19 04:04:33, tapted wrote: > The comment probably isn't necessary, but I think we need to have > > if (ui::ForceClickInvokesQuickLook()) > > since ForceTouch can be configured to do other things in System Prefs Oh yeah, thanks for catching this.
lgtm
The CQ bit was checked by karandeepb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482125912549880,
"parent_rev": "4aac82cf6e8014e939dd66b207b0445d9204c84c", "commit_rev":
"7793c5bf3149a6396e1e0cb225566f1364d7dd07"}
Message was sent while issue was closed.
Description was changed from ========== MacViews: Perform word lookup on force touch. r368481 added support for force touch to the BaseView and r423419 implemented dictionary lookup for views::Textfield on MacViews. This CL implements the method forceTouchEvent: on the BridgedContentView. As a result, force touching on a views::Textfield now performs dictionary lookup for the word under the cursor as per the user's system preferences. BUG=640502 TEST= Enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some text in the name textfield. Force touch on one of the words in the text. Verify that a dictionary popup appears showing the definition of the word under the cursor. ========== to ========== MacViews: Perform word lookup on force touch. r368481 added support for force touch to the BaseView and r423419 implemented dictionary lookup for views::Textfield on MacViews. This CL implements the method forceTouchEvent: on the BridgedContentView. As a result, force touching on a views::Textfield now performs dictionary lookup for the word under the cursor as per the user's system preferences. BUG=640502 TEST= Enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some text in the name textfield. Force touch on one of the words in the text. Verify that a dictionary popup appears showing the definition of the word under the cursor. Review-Url: https://codereview.chromium.org/2587833002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== MacViews: Perform word lookup on force touch. r368481 added support for force touch to the BaseView and r423419 implemented dictionary lookup for views::Textfield on MacViews. This CL implements the method forceTouchEvent: on the BridgedContentView. As a result, force touching on a views::Textfield now performs dictionary lookup for the word under the cursor as per the user's system preferences. BUG=640502 TEST= Enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some text in the name textfield. Force touch on one of the words in the text. Verify that a dictionary popup appears showing the definition of the word under the cursor. Review-Url: https://codereview.chromium.org/2587833002 ========== to ========== MacViews: Perform word lookup on force touch. r368481 added support for force touch to the BaseView and r423419 implemented dictionary lookup for views::Textfield on MacViews. This CL implements the method forceTouchEvent: on the BridgedContentView. As a result, force touching on a views::Textfield now performs dictionary lookup for the word under the cursor as per the user's system preferences. BUG=640502 TEST= Enable chrome://flags/#secondary-ui-md. Open Bookmark Bubble. Enter some text in the name textfield. Force touch on one of the words in the text. Verify that a dictionary popup appears showing the definition of the word under the cursor. Committed: https://crrev.com/8de9c34b9a48e07607bed42939e32ab2f4b79558 Cr-Commit-Position: refs/heads/master@{#439417} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8de9c34b9a48e07607bed42939e32ab2f4b79558 Cr-Commit-Position: refs/heads/master@{#439417} |
