Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2587823002: gpu: Simplify the mapping from BufferFormat to texture type. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
Reviewers:
reveman, jbauman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Simplify the mapping from BufferFormat to texture type. The texture type is always GL_TEXTURE_2D on non-ozone non-macos platforms. Make that more obvious when reading the code. BUG=675431 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/7ac76b9328da7ec9531dab33484242fc3e3f980d Cr-Commit-Position: refs/heads/master@{#439664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M gpu/ipc/host/gpu_memory_buffer_support.cc View 4 chunks +11 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
sadrul
Hi! Let me know if you would prefer that I merge this back to https://codereview.chromium.org/2585653003/
4 years ago (2016-12-19 03:06:37 UTC) #5
reveman
lgtm
4 years ago (2016-12-19 17:27:00 UTC) #8
jbauman
lgtm
4 years ago (2016-12-19 21:47:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587823002/1
4 years ago (2016-12-20 01:50:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 01:55:58 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-20 01:58:22 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ac76b9328da7ec9531dab33484242fc3e3f980d
Cr-Commit-Position: refs/heads/master@{#439664}

Powered by Google App Engine
This is Rietveld 408576698