Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2587783003: [CrOS Tether] Fix miscellaneous issues with HostScanScheduler. (Closed)

Created:
4 years ago by Kyle Horimoto
Modified:
4 years ago
Reviewers:
Ryan Hansberry
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Fix miscellaneous issues with HostScanScheduler. These changes were suggested by tengs@ in https://codereview.chromium.org/2564653004/ after it had already been submitted. BUG=672263 Committed: https://crrev.com/5d06193cd0a5c5b11ebea237ada11ae8d0de9400 Cr-Commit-Position: refs/heads/master@{#439595}

Patch Set 1 #

Total comments: 2

Patch Set 2 : hansberry@ comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -75 lines) Patch
M chromeos/components/tether/host_scan_scheduler.h View 4 chunks +7 lines, -8 lines 0 comments Download
M chromeos/components/tether/host_scan_scheduler.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M chromeos/components/tether/host_scan_scheduler_unittest.cc View 1 8 chunks +54 lines, -53 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Kyle Horimoto
4 years ago (2016-12-19 21:10:30 UTC) #2
Ryan Hansberry
lgtm https://codereview.chromium.org/2587783003/diff/1/chromeos/components/tether/host_scan_scheduler_unittest.cc File chromeos/components/tether/host_scan_scheduler_unittest.cc (right): https://codereview.chromium.org/2587783003/diff/1/chromeos/components/tether/host_scan_scheduler_unittest.cc#newcode22 chromeos/components/tether/host_scan_scheduler_unittest.cc:22: namespace {} // namespace Is this namespace needed?
4 years ago (2016-12-19 21:13:57 UTC) #3
Kyle Horimoto
https://codereview.chromium.org/2587783003/diff/1/chromeos/components/tether/host_scan_scheduler_unittest.cc File chromeos/components/tether/host_scan_scheduler_unittest.cc (right): https://codereview.chromium.org/2587783003/diff/1/chromeos/components/tether/host_scan_scheduler_unittest.cc#newcode22 chromeos/components/tether/host_scan_scheduler_unittest.cc:22: namespace {} // namespace On 2016/12/19 21:13:57, Ryan Hansberry ...
4 years ago (2016-12-19 21:17:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587783003/20001
4 years ago (2016-12-19 21:18:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 22:36:17 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-19 22:38:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d06193cd0a5c5b11ebea237ada11ae8d0de9400
Cr-Commit-Position: refs/heads/master@{#439595}

Powered by Google App Engine
This is Rietveld 408576698