Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2587763003: [turbofan] Pass Runtime::FunctionId to TrapIf and TrapUnless isel methods. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Pass Runtime::FunctionId to TrapIf and TrapUnless isel methods. This also fixes UBSAN failures due to improper OpParameter<> calls. R=machenbach@chromium.org, clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2587763003 Cr-Commit-Position: refs/heads/master@{#41790} Committed: https://chromium.googlesource.com/v8/v8/+/b29d6d4968ffc2ef602df1977c65c6b7fd8f1975

Patch Set 1 #

Patch Set 2 : Fix typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -37 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
titzer
4 years ago (2016-12-19 09:58:29 UTC) #1
Clemens Hammacher
lgtm, but I am not familiar with the modified code.
4 years ago (2016-12-19 10:11:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587763003/20001
4 years ago (2016-12-19 10:40:16 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 10:42:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b29d6d4968ffc2ef602df1977c65c6b7fd8...

Powered by Google App Engine
This is Rietveld 408576698