The DOMPointReadOnly interface requires serializer.

The DOMPointReadOnly interface requires serializer.

The DOMPointReadOnly implementation is different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437
Committed: https://crrev.com/36ea6aa469982de5fbe187e6e1e1df881d36c2d5
Cr-Commit-Position: refs/heads/master@{#440590}

[Byoungkwon Ko, 2016-12-18 13:58:58]

Description was changed from

==========
The DOMPoint/DOMPointReadOnly implementation are different with spec. They
should match up with the spec.

The DOMPointReadOnly interface requires serializer.

BUG=675437
==========

to

==========
The DOMPointReadOnly interface requires serializer.
The DOMPointReadOnly implementation are different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437
==========

[Byoungkwon Ko, 2016-12-18 14:01:35]

Description was changed from

==========
The DOMPointReadOnly interface requires serializer.
The DOMPointReadOnly implementation are different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437
==========

to

==========
The DOMPointReadOnly interface requires serializer.
The DOMPointReadOnly implementation is different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437
==========

[Byoungkwon Ko, 2016-12-18 14:03:52]

Description was changed from

==========
The DOMPointReadOnly interface requires serializer.
The DOMPointReadOnly implementation is different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437
==========

to

==========
The DOMPointReadOnly interface requires serializer.

The DOMPointReadOnly implementation is different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437
==========

[Byoungkwon Ko, 2016-12-18 14:10:55]

gogag2@gmail.com changed reviewers:
+ jinho.bang@samsung.com

[Byoungkwon Ko, 2016-12-18 14:11:15]

On 2016/12/18 14:10:55, Byoungkwon Ko wrote:
> mailto:gogag2@gmail.com changed reviewers:
> + mailto:jinho.bang@samsung.com

PTAL

[zino, 2016-12-18 21:07:52]

jinho.bang@samsung.com changed reviewers:
+ foolip@chromium.org

[zino, 2016-12-18 21:14:40]

On 2016/12/18 14:11:15, Byoungkwon Ko wrote:
> On 2016/12/18 14:10:55, Byoungkwon Ko wrote:
> > mailto:gogag2@gmail.com changed reviewers:
> > + mailto:jinho.bang@samsung.com
> 
> PTAL

lgtm with nit.

foolip@ Could you review this patch?
(I'm not an core owner and dominicc@ is OOO.)

[zino, 2016-12-18 21:14:55]

https://codereview.chromium.org/2587743002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMPointReadOnly.h (right):

https://codereview.chromium.org/2587743002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMPointReadOnly.h:10: #include
"bindings/core/v8/V8ObjectBuilder.h"
nit: This should be moved to cpp file.

[foolip, 2016-12-19 12:33:42]

lgtm % nits, and it would be great to have test like this in
https://github.com/w3c/web-platform-tests since they don't seem to need anything
internal.

If you want to work on that, first create a directory for the spec in
https://github.com/w3c/web-platform-tests with the appropriate OWNERS, and then
upstream a few of our tests as a start.

If you'd like, you can dogfood the https://crbug.com/657117 process, where you
can add tests directly to LayoutTests/imported/wpt/ and have them automatically
exported, which makes this kind of work a lot easier. Just make sure to notify
jeffcarp@ on each such CL, so he can then use it to test the export tooling. And
stop if he says it's too much :)

https://codereview.chromium.org/2587743002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMPointReadOnly.h (right):

https://codereview.chromium.org/2587743002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMPointReadOnly.h:10: #include
"bindings/core/v8/V8ObjectBuilder.h"
On 2016/12/18 21:14:55, zino wrote:
> nit: This should be moved to cpp file.

Yep, and ScriptValue can also be forward declared, but go with the style that's
most common on that point.

[Byoungkwon Ko, 2016-12-19 17:42:07]

Thanks for your review.

I changed DOMPointReadOnly.h and DOMPointReadOnly.cpp as following your
comments.

Dear foolip

I am checking your comment about changing to web-platform-tests.
But I think I need time to complete it.
Could I try it after landing this issue?

And I have a question about your process(https://crbug.com/657117).
Do I add just tests directly to LayoutTests/imported/wpt/ ?
Then can I get exported file?
If you have time, plz check my question : )
Thanks.

[Byoungkwon Ko, 2016-12-22 04:07:06]

I will try it in foloow-up CL after landing this patch.

[Byoungkwon Ko, 2016-12-22 04:07:12]

The CQ bit was checked by gogag2@gmail.com

[Byoungkwon Ko, 2016-12-22 04:07:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
jinho.bang@samsung.com, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2587743002/#ps40001
(title: "The DOMPoint/DOMPointReadOnly implementation are different with spec.
They should match up with the…")

[commit-bot: I haz the power, 2016-12-22 04:07:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 05:47:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 05:47:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[zino, 2016-12-23 01:46:20]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 01:46:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 03:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 03:58:25]

Dry run: This issue passed the CQ dry run.

[Byoungkwon Ko, 2016-12-23 04:48:19]

The CQ bit was checked by gogag2@gmail.com

[Byoungkwon Ko, 2016-12-23 04:48:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
jinho.bang@samsung.com, foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2587743002/#ps60001
(title: "The DOMPointReadOnly interface requires serializer.")

[commit-bot: I haz the power, 2016-12-23 04:48:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 04:52:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482468499432710,
"parent_rev": "484c072208db7222fed33a2dc6949bbfa5668c77", "commit_rev":
"cd3302181129bfc8ff34aa08c0be080abbef2e5a"}

[commit-bot: I haz the power, 2016-12-23 04:53:22]

Description was changed from

==========
The DOMPointReadOnly interface requires serializer.

The DOMPointReadOnly implementation is different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437
==========

to

==========
The DOMPointReadOnly interface requires serializer.

The DOMPointReadOnly implementation is different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437

Review-Url: https://codereview.chromium.org/2587743002
==========

[commit-bot: I haz the power, 2016-12-23 04:53:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-23 04:56:37]

Description was changed from

==========
The DOMPointReadOnly interface requires serializer.

The DOMPointReadOnly implementation is different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437

Review-Url: https://codereview.chromium.org/2587743002
==========

to

==========
The DOMPointReadOnly interface requires serializer.

The DOMPointReadOnly implementation is different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#dompointreadonly

BUG=675437

Committed: https://crrev.com/36ea6aa469982de5fbe187e6e1e1df881d36c2d5
Cr-Commit-Position: refs/heads/master@{#440590}
==========

[commit-bot: I haz the power, 2016-12-23 04:56:39]

Patchset 4 (id:??) landed as
https://crrev.com/36ea6aa469982de5fbe187e6e1e1df881d36c2d5
Cr-Commit-Position: refs/heads/master@{#440590}