Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2587683002: AppShell: enable touch emulation from command line (Closed)

Created:
4 years ago by michaelpg
Modified:
3 years, 11 months ago
Reviewers:
Rahul Chaturvedi
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AppShell: enable touch emulation from command line BUG=675413 R=steel@chromium.org Review-Url: https://codereview.chromium.org/2587683002 Cr-Commit-Position: refs/heads/master@{#442331} Committed: https://chromium.googlesource.com/chromium/src/+/6cc74c86d8ea1cc0ba5fa8de692870f08ddf556a

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Add ui dependencies explicitly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M extensions/shell/BUILD.gn View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Rahul Chaturvedi
https://codereview.chromium.org/2587683002/diff/1/extensions/shell/browser/shell_browser_main_parts.cc File extensions/shell/browser/shell_browser_main_parts.cc (right): https://codereview.chromium.org/2587683002/diff/1/extensions/shell/browser/shell_browser_main_parts.cc#newcode71 extensions/shell/browser/shell_browser_main_parts.cc:71: #include "ui/events/devices/x11/touch_factory_x11.h" // nogncheck Add this to DEPS instead ...
3 years, 11 months ago (2017-01-09 18:25:41 UTC) #1
michaelpg
https://codereview.chromium.org/2587683002/diff/1/extensions/shell/browser/shell_browser_main_parts.cc File extensions/shell/browser/shell_browser_main_parts.cc (right): https://codereview.chromium.org/2587683002/diff/1/extensions/shell/browser/shell_browser_main_parts.cc#newcode71 extensions/shell/browser/shell_browser_main_parts.cc:71: #include "ui/events/devices/x11/touch_factory_x11.h" // nogncheck On 2017/01/09 18:25:40, Rahul Chaturvedi ...
3 years, 11 months ago (2017-01-09 18:59:18 UTC) #3
Rahul Chaturvedi
lgtm
3 years, 11 months ago (2017-01-09 19:02:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587683002/60001
3 years, 11 months ago (2017-01-09 19:03:42 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 20:40:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6cc74c86d8ea1cc0ba5fa8de6928...

Powered by Google App Engine
This is Rietveld 408576698