Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2587603002: Make is_win_fastlink imply -fstandalone-debug for clang (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index f3a69627b3b04726b55af755978481a6a7cd2ff7..b5231b1537587a51bdcf520f1adb0afc7eb91cda 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1560,6 +1560,16 @@ config("symbols") {
} else {
ldflags = [ "/DEBUG" ]
}
+
+ if (is_clang) {
+ # /DEBUG:FASTLINK requires every object file to have standalone debug
+ # information.
+ if (is_win_fastlink) {
+ cflags += [ "-fstandalone-debug" ]
+ } else {
+ cflags += [ "-fno-standalone-debug" ]
+ }
+ }
} else {
if (is_mac || is_ios) {
cflags = [ "-gdwarf-2" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698