Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2587603002: Make is_win_fastlink imply -fstandalone-debug for clang (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1542 matching lines...) Expand 10 before | Expand all | Expand 10 after
1553 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue. 1553 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
1554 1554
1555 if (is_win_fastlink) { 1555 if (is_win_fastlink) {
1556 # Tell VS 2015+ to create a PDB that references debug 1556 # Tell VS 2015+ to create a PDB that references debug
1557 # information in .obj and .lib files instead of copying 1557 # information in .obj and .lib files instead of copying
1558 # it all. This flag is incompatible with /PROFILE 1558 # it all. This flag is incompatible with /PROFILE
1559 ldflags = [ "/DEBUG:FASTLINK" ] 1559 ldflags = [ "/DEBUG:FASTLINK" ]
1560 } else { 1560 } else {
1561 ldflags = [ "/DEBUG" ] 1561 ldflags = [ "/DEBUG" ]
1562 } 1562 }
1563
1564 if (is_clang) {
1565 # /DEBUG:FASTLINK requires every object file to have standalone debug
1566 # information.
1567 if (is_win_fastlink) {
1568 cflags += [ "-fstandalone-debug" ]
1569 } else {
1570 cflags += [ "-fno-standalone-debug" ]
1571 }
1572 }
1563 } else { 1573 } else {
1564 if (is_mac || is_ios) { 1574 if (is_mac || is_ios) {
1565 cflags = [ "-gdwarf-2" ] 1575 cflags = [ "-gdwarf-2" ]
1566 if (is_mac && enable_dsyms) { 1576 if (is_mac && enable_dsyms) {
1567 # If generating dSYMs, specify -fno-standalone-debug. This was 1577 # If generating dSYMs, specify -fno-standalone-debug. This was
1568 # originally specified for https://crbug.com/479841 because dsymutil 1578 # originally specified for https://crbug.com/479841 because dsymutil
1569 # could not handle a 4GB dSYM file. But dsymutil from Xcodes prior to 1579 # could not handle a 4GB dSYM file. But dsymutil from Xcodes prior to
1570 # version 7 also produces debug data that is incompatible with Breakpad 1580 # version 7 also produces debug data that is incompatible with Breakpad
1571 # dump_syms, so this is still required (https://crbug.com/622406). 1581 # dump_syms, so this is still required (https://crbug.com/622406).
1572 cflags += [ "-fno-standalone-debug" ] 1582 cflags += [ "-fno-standalone-debug" ]
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
1639 1649
1640 if (is_ios || is_mac) { 1650 if (is_ios || is_mac) {
1641 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1651 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1642 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1652 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1643 config("enable_arc") { 1653 config("enable_arc") {
1644 common_flags = [ "-fobjc-arc" ] 1654 common_flags = [ "-fobjc-arc" ]
1645 cflags_objc = common_flags 1655 cflags_objc = common_flags
1646 cflags_objcc = common_flags 1656 cflags_objcc = common_flags
1647 } 1657 }
1648 } 1658 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698