Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2587563002: Mouse up updates scrollbar hovered part if needed. (Closed)

Created:
4 years ago by sahel
Modified:
4 years ago
Reviewers:
bokan, esprehn
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mouse up updates scrollbar hovered part if needed. BUG=671214 TEST=WebFrameTest.MouseReleaseUpdatesScrollbarHoveredPart Committed: https://crrev.com/db90376264139744e86f2fbc55ead46c2d55bf15 Cr-Commit-Position: refs/heads/master@{#439628}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h View 1 chunk +5 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
sahel
4 years ago (2016-12-19 15:29:34 UTC) #6
bokan
lgtm https://codereview.chromium.org/2587563002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h File third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h (right): https://codereview.chromium.org/2587563002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h#newcode63 third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h:63: return false; This is fine, but was it ...
4 years ago (2016-12-19 18:23:50 UTC) #7
sahel
esprehn@chromium.org: Please review changes in https://codereview.chromium.org/2587563002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h File third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h (right): https://codereview.chromium.org/2587563002/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h#newcode63 third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h:63: return false; On 2016/12/19 ...
4 years ago (2016-12-19 19:05:53 UTC) #9
esprehn
lgtm
4 years ago (2016-12-19 21:57:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587563002/1
4 years ago (2016-12-19 22:12:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 00:12:08 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-20 00:13:37 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db90376264139744e86f2fbc55ead46c2d55bf15
Cr-Commit-Position: refs/heads/master@{#439628}

Powered by Google App Engine
This is Rietveld 408576698