Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2587533002: DevTools: consistently use relative name for filesystem resources. (Closed)

Created:
4 years ago by pfeldman
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: consistently use relative name for filesystem resources. Committed: https://crrev.com/6a8b2a3e8c610e87a751ebd281832af80c3d04fb Cr-Commit-Position: refs/heads/master@{#439648}

Patch Set 1 #

Patch Set 2 : rebaselined #

Patch Set 3 : same #

Messages

Total messages: 24 (13 generated)
pfeldman
4 years ago (2016-12-16 20:01:28 UTC) #2
lushnikov
The patch is good by itself, but I don't understand what it fixes. Could you ...
4 years ago (2016-12-16 20:10:18 UTC) #3
pfeldman
On 2016/12/16 20:10:18, lushnikov wrote: > The patch is good by itself, but I don't ...
4 years ago (2016-12-16 20:26:02 UTC) #4
lushnikov
lgtm
4 years ago (2016-12-16 21:42:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587533002/1
4 years ago (2016-12-16 21:43:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/279844) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years ago (2016-12-16 21:47:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587533002/40001
4 years ago (2016-12-17 00:22:05 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/358564)
4 years ago (2016-12-17 01:36:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587533002/40001
4 years ago (2016-12-19 22:53:17 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-20 01:13:11 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-20 01:17:11 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a8b2a3e8c610e87a751ebd281832af80c3d04fb
Cr-Commit-Position: refs/heads/master@{#439648}

Powered by Google App Engine
This is Rietveld 408576698