Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: base/security_unittest.cc

Issue 25875004: Roll Clang 188423:191856. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable MultiThreadedCertVerifierTest.CancelRequestThenQuit for LSan Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/stack_trace_android.cc ('k') | build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/security_unittest.cc
diff --git a/base/security_unittest.cc b/base/security_unittest.cc
index 5b266b0a11c434b480e54ee3ad1fa8fbcdd25ce9..8f5921973000fd935036f618a658f5341b27c547 100644
--- a/base/security_unittest.cc
+++ b/base/security_unittest.cc
@@ -75,14 +75,11 @@ bool IsTcMallocBypassed() {
}
bool CallocDiesOnOOM() {
+// The sanitizers' calloc dies on OOM instead of returning NULL.
// The wrapper function in base/process_util_linux.cc that is used when we
// compile without TCMalloc will just die on OOM instead of returning NULL.
-// This function is explicitly disabled if we compile with AddressSanitizer,
-// MemorySanitizer or ThreadSanitizer.
-#if defined(OS_LINUX) && defined(NO_TCMALLOC) && \
- (!defined(ADDRESS_SANITIZER) && \
- !defined(MEMORY_SANITIZER) && \
- !defined(THREAD_SANITIZER))
+#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER) || \
+ defined(THREAD_SANITIZER) || (defined(OS_LINUX) && defined(NO_TCMALLOC))
return true;
#else
return false;
« no previous file with comments | « base/debug/stack_trace_android.cc ('k') | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698