devil: Make provision_devices.py complain when no devices are available.

devil: Make provision_devices.py complain when no devices are available.

BUG=chromium:674473
Review-Url: https://codereview.chromium.org/2587493002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/425ce1642fdc1f3b7aa29dd4fea57e55361dfd8e

[bpastene, 2016-12-16 18:32:41]

bpastene@chromium.org changed reviewers:
+ jbudorick@chromium.org

[bpastene, 2016-12-16 18:32:41]

Should I bother making these changes to src's version as well?

[jbudorick, 2016-12-16 18:42:04]

- lgtm w/ nits
- don't worry about porting this to src/
- we may also want to make device_recovery exit w/ an error if it has no
available devices when it finishes

https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/p...
File devil/devil/android/tools/provision_devices.py (right):

https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/p...
devil/devil/android/tools/provision_devices.py:96: 'Local device blacklist: %s.
Consider clearing the file.',
Clearing the blacklist isn't usually relevant advice here. Provisioning runs
immediately after device_recovery in most configurations, and that clears the
blacklist and then adds devices back to it as necessary.

https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/s...
File devil/devil/android/tools/script_common.py (right):

https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/s...
devil/devil/android/tools/script_common.py:12: blacklist =
(device_blacklist.Blacklist(blacklist_file)
maybe we just rename this to blacklist_file?

[bpastene, 2016-12-16 20:06:34]

https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/p...
File devil/devil/android/tools/provision_devices.py (right):

https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/p...
devil/devil/android/tools/provision_devices.py:96: 'Local device blacklist: %s.
Consider clearing the file.',
On 2016/12/16 18:42:04, jbudorick wrote:
> Clearing the blacklist isn't usually relevant advice here. Provisioning runs
> immediately after device_recovery in most configurations, and that clears the
> blacklist and then adds devices back to it as necessary.

Alright, I'll remove the suggestion, but I still think dumping the blacklist
might be useful.

https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/s...
File devil/devil/android/tools/script_common.py (right):

https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/s...
devil/devil/android/tools/script_common.py:12: blacklist =
(device_blacklist.Blacklist(blacklist_file)
On 2016/12/16 18:42:04, jbudorick wrote:
> maybe we just rename this to blacklist_file?

Sure

[bpastene, 2016-12-16 20:07:08]

The CQ bit was checked by bpastene@chromium.org

[bpastene, 2016-12-16 20:07:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2587493002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-12-16 20:07:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2016-12-16 20:07:28]

On 2016/12/16 20:06:34, bpastene wrote:
>
https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/p...
> File devil/devil/android/tools/provision_devices.py (right):
> 
>
https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/p...
> devil/devil/android/tools/provision_devices.py:96: 'Local device blacklist:
%s.
> Consider clearing the file.',
> On 2016/12/16 18:42:04, jbudorick wrote:
> > Clearing the blacklist isn't usually relevant advice here. Provisioning runs
> > immediately after device_recovery in most configurations, and that clears
the
> > blacklist and then adds devices back to it as necessary.
> 
> Alright, I'll remove the suggestion, but I still think dumping the blacklist
> might be useful.

Printing it certainly is. Clearing it likely isn't.

> 
>
https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/s...
> File devil/devil/android/tools/script_common.py (right):
> 
>
https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/s...
> devil/devil/android/tools/script_common.py:12: blacklist =
> (device_blacklist.Blacklist(blacklist_file)
> On 2016/12/16 18:42:04, jbudorick wrote:
> > maybe we just rename this to blacklist_file?
> 
> Sure

[commit-bot: I haz the power, 2016-12-16 20:37:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481918828682230,
"parent_rev": "c1005608b3ea0a12295838d86951080332abea12", "commit_rev":
"425ce1642fdc1f3b7aa29dd4fea57e55361dfd8e"}

[commit-bot: I haz the power, 2016-12-16 20:37:28]

Description was changed from

==========
devil: Make provision_devices.py complain when no devices are available.

BUG=chromium:674473
==========

to

==========
devil: Make provision_devices.py complain when no devices are available.

BUG=chromium:674473

Review-Url: https://codereview.chromium.org/2587493002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-12-16 20:37:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...