Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2587493002: devil: Make provision_devices.py complain when no devices are available. (Closed)

Created:
4 years ago by bpastene
Modified:
4 years ago
Reviewers:
jbudorick
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M devil/devil/android/tools/provision_devices.py View 1 2 chunks +8 lines, -1 line 0 comments Download
M devil/devil/android/tools/script_common.py View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bpastene
Should I bother making these changes to src's version as well?
4 years ago (2016-12-16 18:32:41 UTC) #2
jbudorick
- lgtm w/ nits - don't worry about porting this to src/ - we may ...
4 years ago (2016-12-16 18:42:04 UTC) #3
bpastene
https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/provision_devices.py File devil/devil/android/tools/provision_devices.py (right): https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/provision_devices.py#newcode96 devil/devil/android/tools/provision_devices.py:96: 'Local device blacklist: %s. Consider clearing the file.', On ...
4 years ago (2016-12-16 20:06:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587493002/20001
4 years ago (2016-12-16 20:07:20 UTC) #7
jbudorick
On 2016/12/16 20:06:34, bpastene wrote: > https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/provision_devices.py > File devil/devil/android/tools/provision_devices.py (right): > > https://codereview.chromium.org/2587493002/diff/1/devil/devil/android/tools/provision_devices.py#newcode96 > ...
4 years ago (2016-12-16 20:07:28 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-16 20:37:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698