Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_test_util.h

Issue 2587443002: predictors: Make speculative_prefetch_predictor work with PlzNavigate (Closed)
Patch Set: From SessionID to SessionID::id_type Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_predictor_test_util.h
diff --git a/chrome/browser/predictors/resource_prefetch_predictor_test_util.h b/chrome/browser/predictors/resource_prefetch_predictor_test_util.h
index bd72225256f72fc6d67cd05cb42610512fa1d7b6..7df21fed4c2b5f75c3c4214e033f3ebeb3d57e2e 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor_test_util.h
+++ b/chrome/browser/predictors/resource_prefetch_predictor_test_util.h
@@ -34,8 +34,7 @@ PrefetchData CreatePrefetchData(const std::string& primary_key,
RedirectData CreateRedirectData(const std::string& primary_key,
uint64_t last_visit_time = 0);
-NavigationID CreateNavigationID(int process_id,
- int render_frame_id,
+NavigationID CreateNavigationID(int session_id,
Benoit L 2016/12/20 09:53:39 SessionID is not an int, it's a SessionID::id_type
ahemery 2016/12/20 13:00:00 Updated with proper type
const std::string& main_frame_url);
ResourcePrefetchPredictor::PageRequestSummary CreatePageRequestSummary(
@@ -45,8 +44,7 @@ ResourcePrefetchPredictor::PageRequestSummary CreatePageRequestSummary(
subresource_requests);
ResourcePrefetchPredictor::URLRequestSummary CreateURLRequestSummary(
- int process_id,
- int render_frame_id,
+ int tab_id,
Benoit L 2016/12/20 09:53:39 nit: There is session_id and tab_id in the code. I
ahemery 2016/12/20 13:00:00 Everything unified to session_id
alexilin 2016/12/20 14:06:47 The same remark about SessionID::id_type.
const std::string& main_frame_url,
const std::string& resource_url = std::string(),
content::ResourceType resource_type = content::RESOURCE_TYPE_MAIN_FRAME,

Powered by Google App Engine
This is Rietveld 408576698