predictors: Make speculative_prefetch_predictor work with PlzNavigate

chrome/browser/predictors/resource_prefetch_predictor_test_util.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef CHROME_BROWSER_PREDICTORS_RESOURCE_PREFETCH_PREDICTOR_TEST_UTIL_H_
 #define CHROME_BROWSER_PREDICTORS_RESOURCE_PREFETCH_PREDICTOR_TEST_UTIL_H_
 
 #include <string>
 #include <vector>
 
 #include "chrome/browser/predictors/resource_prefetch_predictor.h"
@@ skipping 16 matching lines @@
                             const std::string& url,
                             int number_of_hits,
                             int number_of_misses,
                             int consecutive_misses);
 
 PrefetchData CreatePrefetchData(const std::string& primary_key,
                                 uint64_t last_visit_time = 0);
 RedirectData CreateRedirectData(const std::string& primary_key,
                                 uint64_t last_visit_time = 0);
 
-NavigationID CreateNavigationID(int process_id,
-                                int render_frame_id,
+NavigationID CreateNavigationID(int session_id,

[Benoit L, 2016/12/20 09:53:39]

SessionID is not an int, it's a SessionID::id_type. Please use this type.

[ahemery, 2016/12/20 13:00:00]

Updated with proper type

                                 const std::string& main_frame_url);
 
 ResourcePrefetchPredictor::PageRequestSummary CreatePageRequestSummary(
     const std::string& main_frame_url,
     const std::string& initial_url,
     const std::vector<ResourcePrefetchPredictor::URLRequestSummary>&
         subresource_requests);
 
 ResourcePrefetchPredictor::URLRequestSummary CreateURLRequestSummary(
-    int process_id,
-    int render_frame_id,
+    int tab_id,

[Benoit L, 2016/12/20 09:53:39]

nit: There is session_id and tab_id in the code. It's better to use only one of
them consistently, this reduces confusion.

[ahemery, 2016/12/20 13:00:00]

Everything unified to session_id

[alexilin, 2016/12/20 14:06:47]

The same remark about SessionID::id_type.

     const std::string& main_frame_url,
     const std::string& resource_url = std::string(),
     content::ResourceType resource_type = content::RESOURCE_TYPE_MAIN_FRAME,
     net::RequestPriority priority = net::MEDIUM,
     const std::string& mime_type = std::string(),
     bool was_cached = false,
     const std::string& redirect_url = std::string(),
     bool has_validators = false,
     bool always_revalidate = false);
 
@@ skipping 15 matching lines @@
 bool operator==(const RedirectData& lhs, const RedirectData& rhs);
 bool operator==(const RedirectStat& lhs, const RedirectStat& rhs);
 bool operator==(const ResourcePrefetchPredictor::PageRequestSummary& lhs,
                 const ResourcePrefetchPredictor::PageRequestSummary& rhs);
 bool operator==(const ResourcePrefetchPredictor::URLRequestSummary& lhs,
                 const ResourcePrefetchPredictor::URLRequestSummary& rhs);
 
 }  // namespace predictors
 
 #endif  // CHROME_BROWSER_PREDICTORS_RESOURCE_PREFETCH_PREDICTOR_TEST_UTIL_H_