Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2587413004:
Handle mp4a.a5 and mp4a.a6 codec ids in StringToAudioCodec (Closed)
|
Created:
4 years ago by servolk Modified:
3 years, 11 months ago Reviewers:
chcunningham CC:
chromium-reviews, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionHandle mp4a.a5 and mp4a.a6 codec ids in StringToAudioCodec
We currently allow AC3/EAC3 codec id variants lower-case OTIs,
i.e. mp4a.a5 and mp4a.a6 in most places (e.g. stream_parser_factory.cc
and mime_util_internal.cc). We also need to support those lower-case
variants in StringToAudioCodec, since otherwise they won't get
recognized when an app adds a source buffer with that codec id and it's
checked in SourceBufferState::Init.
BUG=internal b/33554560
Committed: https://crrev.com/edcc8976094f4f678f9d82a58ab8e7c39f2c21cf
Cr-Commit-Position: refs/heads/master@{#441281}
Patch Set 1 #
Messages
Total messages: 19 (14 generated)
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Handle mp4a.a5 and mp4a.a6 codec ids in StringToAudioCodec We currently allow AC3/EAC3 codec id variants lower-case OTIs, i.e. mp4a.a5 and mp4a.a6 in most places (e.g. stream_parser_factory.cc and mime_util_internal.cc). We also need to support those lower-case variants in StringToAudioCodec, since otherwise they won't get recognized when an app adds a source buffer with that codec id and it's checked in SourceBufferState::Init. BUG=internal b/33554560 ========== to ========== Handle mp4a.a5 and mp4a.a6 codec ids in StringToAudioCodec We currently allow AC3/EAC3 codec id variants lower-case OTIs, i.e. mp4a.a5 and mp4a.a6 in most places (e.g. stream_parser_factory.cc and mime_util_internal.cc). We also need to support those lower-case variants in StringToAudioCodec, since otherwise they won't get recognized when an app adds a source buffer with that codec id and it's checked in SourceBufferState::Init. BUG=internal b/33554560 ==========
servolk@chromium.org changed reviewers: + chcunningham@chromium.org
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by servolk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1483492868713180, "parent_rev":
"49cb274f2e50a1fa289da4fb87d723ae3fd2a970", "commit_rev":
"865a699e7404eda693a1650499b56a8561fdc75d"}
Message was sent while issue was closed.
Description was changed from ========== Handle mp4a.a5 and mp4a.a6 codec ids in StringToAudioCodec We currently allow AC3/EAC3 codec id variants lower-case OTIs, i.e. mp4a.a5 and mp4a.a6 in most places (e.g. stream_parser_factory.cc and mime_util_internal.cc). We also need to support those lower-case variants in StringToAudioCodec, since otherwise they won't get recognized when an app adds a source buffer with that codec id and it's checked in SourceBufferState::Init. BUG=internal b/33554560 ========== to ========== Handle mp4a.a5 and mp4a.a6 codec ids in StringToAudioCodec We currently allow AC3/EAC3 codec id variants lower-case OTIs, i.e. mp4a.a5 and mp4a.a6 in most places (e.g. stream_parser_factory.cc and mime_util_internal.cc). We also need to support those lower-case variants in StringToAudioCodec, since otherwise they won't get recognized when an app adds a source buffer with that codec id and it's checked in SourceBufferState::Init. BUG=internal b/33554560 Review-Url: https://codereview.chromium.org/2587413004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Handle mp4a.a5 and mp4a.a6 codec ids in StringToAudioCodec We currently allow AC3/EAC3 codec id variants lower-case OTIs, i.e. mp4a.a5 and mp4a.a6 in most places (e.g. stream_parser_factory.cc and mime_util_internal.cc). We also need to support those lower-case variants in StringToAudioCodec, since otherwise they won't get recognized when an app adds a source buffer with that codec id and it's checked in SourceBufferState::Init. BUG=internal b/33554560 Review-Url: https://codereview.chromium.org/2587413004 ========== to ========== Handle mp4a.a5 and mp4a.a6 codec ids in StringToAudioCodec We currently allow AC3/EAC3 codec id variants lower-case OTIs, i.e. mp4a.a5 and mp4a.a6 in most places (e.g. stream_parser_factory.cc and mime_util_internal.cc). We also need to support those lower-case variants in StringToAudioCodec, since otherwise they won't get recognized when an app adds a source buffer with that codec id and it's checked in SourceBufferState::Init. BUG=internal b/33554560 Committed: https://crrev.com/edcc8976094f4f678f9d82a58ab8e7c39f2c21cf Cr-Commit-Position: refs/heads/master@{#441281} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/edcc8976094f4f678f9d82a58ab8e7c39f2c21cf Cr-Commit-Position: refs/heads/master@{#441281} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
