Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2587413002: [es6] Fix the %TypedArray% constructor. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Jarin, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix the %TypedArray% constructor. The %TypedArray% constructor must not ever try to construct an instance, but rather throw a TypeError instead. R=jarin@chromium.org BUG=v8:5763 Review-Url: https://codereview.chromium.org/2587413002 Cr-Commit-Position: refs/heads/master@{#41868} Committed: https://chromium.googlesource.com/v8/v8/+/3d9c77d8126a8f48c3acb347cbf382052a9824ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M src/js/typedarray.js View 1 chunk +1 line, -6 lines 0 comments Download
A test/mjsunit/regress/regress-5763-1.js View 1 chunk +11 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-5763-2.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Benedikt Meurer
4 years ago (2016-12-20 13:33:54 UTC) #1
Yang
lgtm
4 years ago (2016-12-20 13:49:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587413002/1
4 years ago (2016-12-20 16:12:33 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 16:14:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3d9c77d8126a8f48c3acb347cbf382052a9...

Powered by Google App Engine
This is Rietveld 408576698