Add tangentialPressure and twist properties to PointerEvent on Mac

Add tangentialPressure and twist properties to PointerEvent on Mac

Set the properties of tangentialPressure and twist for WebMouseEvent of stylus type,
which is created from NSEvent in WebMouseEventBuilder::Build.

Intent to implement and ship: PointerEvent.tangentialPressure and PointerEvent.twist:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-NmHZqP4cQg

BUG=649376
Review-Url: https://codereview.chromium.org/2587393004
Cr-Commit-Position: refs/heads/master@{#444792}
Committed: https://chromium.googlesource.com/chromium/src/+/dcc9534ac96ac852f430c6c76b0c2f8521d851ae

[lanwei, 2016-12-31 03:47:51]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-31 03:47:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2016-12-31 05:11:05]

Description was changed from

==========
pressure


 pressure

BUG=
==========

to

==========
Add tangentialPressure and twist properties to PointerEvent on Mac

Set the properties of tangentialPressure and twist for WebMouseEvent of stylus
type,
which is created from NSEvent in WebMouseEventBuilder::Build.


BUG=
==========

[commit-bot: I haz the power, 2016-12-31 05:27:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-31 05:27:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lanwei, 2016-12-31 05:34:12]

Description was changed from

==========
Add tangentialPressure and twist properties to PointerEvent on Mac

Set the properties of tangentialPressure and twist for WebMouseEvent of stylus
type,
which is created from NSEvent in WebMouseEventBuilder::Build.


BUG=
==========

to

==========
Add tangentialPressure and twist properties to PointerEvent on Mac

Set the properties of tangentialPressure and twist for WebMouseEvent of stylus
type,
which is created from NSEvent in WebMouseEventBuilder::Build.


BUG=649376
==========

[lanwei, 2016-12-31 05:36:49]

lanwei@chromium.org changed reviewers:
+ dtapuska@chromium.org, mustaq@chromium.org, nzolghadr@chromium.org,
rbyers@chromium.org

[lanwei, 2017-01-01 04:20:00]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-01 04:20:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-01 05:56:35]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-01 05:56:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-01 05:59:18]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-01-01 07:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-01 07:17:42]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-01-02 01:29:23]

Patchset #2 (id:40001) has been deleted

[dtapuska, 2017-01-03 18:32:48]

We need to test the initialization of these fields.

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEvent.h (right):

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEvent.h:53: float
m_tangentialPressure;
should this be a double to preserve data from javascript?

[mustaq, 2017-01-03 19:09:24]

https://codereview.chromium.org/2587393004/diff/60001/content/browser/rendere...
File content/browser/renderer_host/input/web_input_event_builders_mac.mm
(right):

https://codereview.chromium.org/2587393004/diff/60001/content/browser/rendere...
content/browser/renderer_host/input/web_input_event_builders_mac.mm:351:
result.twist = [event rotation];
The NSEvent spec doesn't specify the range at all, so we have to be careful
here:
https://developer.apple.com/reference/appkit/nsevent/1526249-rotation

Let's clamp NSEvent.rotation values within [0,360), including for negative
values.

Curious: did you see [0,359] in practice?

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEvent.h (right):

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEvent.h:53: float
m_tangentialPressure;
On 2017/01/03 18:32:48, dtapuska wrote:
> should this be a double to preserve data from javascript?

I think this is fine because the spec specifies "float", and the WebIDL "float"
is IEEE single precision:
https://www.w3.org/TR/WebIDL/#idl-float

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebPointerProperties.h (right):

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebPointerProperties.h:65: // position of the
control. Alwasy 0 if the device does not support it.
Please also add "(or barrel pressure)" in the first line. "Barrel" seems more
intuitive to me.

Also a nit: s/Alwasy/Always/.

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebPointerProperties.h:69: // degrees of a
range of [0,359]). Alwasy 0 if the device does not support
Nit: "in degrees in the range [0,359]."

[Navid Zolghadr, 2017-01-03 21:05:53]

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imported/wpt/pointerevents/idlharness-expected.txt
(right):

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imported/wpt/pointerevents/idlharness-expected.txt:55:
FAIL PointerEvent interface: existence and properties of interface prototype
object assert_equals: class string of PointerEvent.prototype expected "[object
PointerEventPrototype]" but got "[object PointerEvent]"
Rick, what is this that we are failing? I don't quite understand the error. I
thought after adding the twist and tangentialPressure we should be done with
this test.

[lanwei, 2017-01-05 04:16:30]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 04:16:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 07:33:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 07:33:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lanwei, 2017-01-05 16:01:13]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 16:01:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-05 16:04:27]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 16:04:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-01-05 16:04:54]

Patchset #4 (id:100001) has been deleted

[lanwei, 2017-01-05 16:12:07]

Patchset #3 (id:80001) has been deleted

[lanwei, 2017-01-05 16:13:41]

https://codereview.chromium.org/2587393004/diff/60001/content/browser/rendere...
File content/browser/renderer_host/input/web_input_event_builders_mac.mm
(right):

https://codereview.chromium.org/2587393004/diff/60001/content/browser/rendere...
content/browser/renderer_host/input/web_input_event_builders_mac.mm:351:
result.twist = [event rotation];
On 2017/01/03 19:09:24, mustaq wrote:
> The NSEvent spec doesn't specify the range at all, so we have to be careful
> here:
> https://developer.apple.com/reference/appkit/nsevent/1526249-rotation
> 
> Let's clamp NSEvent.rotation values within [0,360), including for negative
> values.
> 
> Curious: did you see [0,359] in practice?
> 

Done. Yes, the value I saw is in this range.

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEvent.h (right):

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEvent.h:53: float
m_tangentialPressure;
On 2017/01/03 19:09:24, mustaq wrote:
> On 2017/01/03 18:32:48, dtapuska wrote:
> > should this be a double to preserve data from javascript?
> 
> I think this is fine because the spec specifies "float", and the WebIDL
"float"
> is IEEE single precision:
> https://www.w3.org/TR/WebIDL/#idl-float

Acknowledged.

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebPointerProperties.h (right):

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebPointerProperties.h:65: // position of the
control. Alwasy 0 if the device does not support it.
On 2017/01/03 19:09:24, mustaq wrote:
> Please also add "(or barrel pressure)" in the first line. "Barrel" seems more
> intuitive to me.
> 
> Also a nit: s/Alwasy/Always/.

Done.

https://codereview.chromium.org/2587393004/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebPointerProperties.h:69: // degrees of a
range of [0,359]). Alwasy 0 if the device does not support
On 2017/01/03 19:09:24, mustaq wrote:
> Nit: "in degrees in the range [0,359]."

Done.

[mustaq, 2017-01-05 16:37:37]

Please also add these fields in the test
fast/events/constructors/pointer-event-constructor.html.

[commit-bot: I haz the power, 2017-01-05 20:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:57:10]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-01-06 01:04:08]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:05:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 03:05:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:05:39]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-01-06 03:44:32]

I added two properties into the constructor test file, could you please take
another look, thanks?

[mustaq, 2017-01-06 15:20:42]

LGTM.

We need an intent to implement & ship. Before committing, please add a link to
the intent thread in the CL description.

[Rick Byers, 2017-01-06 21:51:18]

On 2017/01/06 15:20:42, mustaq wrote:
> LGTM.
> 
> We need an intent to implement & ship. Before committing, please add a link to
> the intent thread in the CL description.

Looks good to me too.  I'll approve once there's an approved i2s.
Alternately if you prefer (eg. if there ends up being debate or delay on the
intent thread) you could land this now with a status=experimental
RuntimeEnabledFeature and flip it to status=stable after the i2s is approved.

[lanwei, 2017-01-10 18:57:40]

Description was changed from

==========
Add tangentialPressure and twist properties to PointerEvent on Mac

Set the properties of tangentialPressure and twist for WebMouseEvent of stylus
type,
which is created from NSEvent in WebMouseEventBuilder::Build.


BUG=649376
==========

to

==========
Add tangentialPressure and twist properties to PointerEvent on Mac

Set the properties of tangentialPressure and twist for WebMouseEvent of stylus
type,
which is created from NSEvent in WebMouseEventBuilder::Build.

Intent to implement and ship: PointerEvent.tangentialPressure and
PointerEvent.twist:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-NmHZqP4cQg

BUG=649376
==========

[lanwei, 2017-01-10 18:58:42]

I sent out an Intent to implement and ship, could you please take another look,
thanks?

[Rick Byers, 2017-01-10 19:13:38]

On 2017/01/10 18:58:42, lanwei wrote:
> I sent out an Intent to implement and ship, could you please take another
look,
> thanks?

Just waiting on three LGs on the thread...

[dtapuska, 2017-01-19 15:08:10]

On 2017/01/10 19:13:38, Rick Byers wrote:
> On 2017/01/10 18:58:42, lanwei wrote:
> > I sent out an Intent to implement and ship, could you please take another
> look,
> > thanks?
> 
> Just waiting on three LGs on the thread...

lgtm. Rick can you lgtm now that this is approved?

[Rick Byers, 2017-01-19 15:32:08]

LGTM

[dtapuska, 2017-01-19 15:42:56]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2017-01-19 15:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 15:45:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 15:45:40]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lanwei, 2017-01-19 16:43:07]

The CQ bit was checked by lanwei@chromium.org

[lanwei, 2017-01-19 16:43:07]

The patchset sent to the CQ was uploaded after l-g-t-m from mustaq@chromium.org,
dtapuska@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2587393004/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-19 16:43:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 18:28:32]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484844187401550,
"parent_rev": "0b6e266b8955aa81a7dcc4ea4d3796e5be9f7cce", "commit_rev":
"dcc9534ac96ac852f430c6c76b0c2f8521d851ae"}

[commit-bot: I haz the power, 2017-01-19 18:29:08]

Description was changed from

==========
Add tangentialPressure and twist properties to PointerEvent on Mac

Set the properties of tangentialPressure and twist for WebMouseEvent of stylus
type,
which is created from NSEvent in WebMouseEventBuilder::Build.

Intent to implement and ship: PointerEvent.tangentialPressure and
PointerEvent.twist:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-NmHZqP4cQg

BUG=649376
==========

to

==========
Add tangentialPressure and twist properties to PointerEvent on Mac

Set the properties of tangentialPressure and twist for WebMouseEvent of stylus
type,
which is created from NSEvent in WebMouseEventBuilder::Build.

Intent to implement and ship: PointerEvent.tangentialPressure and
PointerEvent.twist:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-NmHZqP4cQg

BUG=649376

Review-Url: https://codereview.chromium.org/2587393004
Cr-Commit-Position: refs/heads/master@{#444792}
Committed:
https://chromium.googlesource.com/chromium/src/+/dcc9534ac96ac852f430c6c76b0c...
==========

[commit-bot: I haz the power, 2017-01-19 18:29:10]

Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/dcc9534ac96ac852f430c6c76b0c...

[jeffcarp, 2017-01-24 02:06:21]

On 2017/01/19 at 18:29:10, commit-bot wrote:
> Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/dcc9534ac96ac852f430c6c76b0c...

Not sure if you were already aware, but since this has changes in exported/wpt
it got exported to WPT (just FYI):
https://github.com/w3c/web-platform-tests/pull/4606