Description[spellcheck] Updated Hunspell to 1.6.0
To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.
The license requirements were approved, by having README.chromium
specify which license it was using.
To provide more history: We noticed 2 problems with the latest version of Hunspell (circa 1.5.3 ?). One was that a fuzzer test was complaining about reading (?) off the end of an array. The other was that unit tests would many times fail due to time-out. Specifically, that generating suggestions was taking too long.
I tracked down both issues and submitted patches to the project. Initially I was simply going to make 2 CLs for the issues, but Hunspell integrated the fixes quickly and cut 1.6.0, so I just grabbed that.
Technically, they didn't take my conservative fuzzer fix, but instead made a more targetted one. Also, they made some additional optimizations.
In case it helps someone, we are now sync'd to github hash 2ef84638b8da4c4229242b98fb67131ece334e09.
BUG=673424
Patch Set 1 #Patch Set 2 : Pulled in another optimization #Patch Set 3 : Update to 1.6.0 #Patch Set 4 : Updated README.chromium #Patch Set 5 : Fix README symlink #
Total comments: 4
Patch Set 6 : Fixed last minute differences #Patch Set 7 : Handled presubmit warnings #
Created: 3 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 28 (17 generated)
|