[spellcheck] Updated Hunspell to 1.6.0

[spellcheck] Updated Hunspell to 1.6.0

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

The license requirements were approved, by having README.chromium
specify which license it was using.

To provide more history: We noticed 2 problems with the latest version of Hunspell (circa 1.5.3 ?). One was that a fuzzer test was complaining about reading (?) off the end of an array. The other was that unit tests would many times fail due to time-out. Specifically, that generating suggestions was taking too long.

I tracked down both issues and submitted patches to the project. Initially I was simply going to make 2 CLs for the issues, but Hunspell integrated the fixes quickly and cut 1.6.0, so I just grabbed that. 

Technically, they didn't take my conservative fuzzer fix, but instead made a more targetted one. Also, they made some additional optimizations.

In case it helps someone, we are now sync'd to github hash 2ef84638b8da4c4229242b98fb67131ece334e09.

BUG=673424

[Kevin Bailey, 2016-12-20 20:31:56]

Description was changed from

==========
[spellcheck] Updated Hunspell to patches after 1.5.4

Mostly to pick up our upstreamed optimization for suggestions.

BUG=673424
==========

to

==========
[spellcheck] Updated Hunspell to patches after 1.5.4

Mostly to pick up our upstreamed optimization for suggestions.

BUG=673424
==========

[Kevin Bailey, 2016-12-20 20:31:57]

krb@chromium.org changed reviewers:
+ groby@chromium.org

[Kevin Bailey, 2016-12-20 20:36:46]

The recent changes did not collide with our patches; fairly minor. Tests still
pass and suggestions run quickly.

One thing to note is that COPYING{.LGPL->.LESSER} changed to v3. This appears to
me to be ok since everything I read says, "or later", but note that the
individual files (*.cxx,hxx) still have the older license inlined.

[groby-ooo-7-16, 2016-12-23 00:27:40]

On 2016/12/20 20:36:46, Kevin Bailey wrote:
> The recent changes did not collide with our patches; fairly minor. Tests still
> pass and suggestions run quickly.
> 
> One thing to note is that COPYING{.LGPL->.LESSER} changed to v3. This appears
to
> me to be ok since everything I read says, "or later", but note that the
> individual files (*.cxx,hxx) still have the older license inlined.

LGTM with caveat that you should double-check licensing w/ pcounsel

[Kevin Bailey, 2017-01-06 15:10:09]

Description was changed from

==========
[spellcheck] Updated Hunspell to patches after 1.5.4

Mostly to pick up our upstreamed optimization for suggestions.

BUG=673424
==========

to

==========
[spellcheck] Updated Hunspell to 1.6.0

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

BUG=673424
==========

[Kevin Bailey, 2017-01-06 15:14:42]

On 2016/12/23 00:27:40, groby wrote:
> On 2016/12/20 20:36:46, Kevin Bailey wrote:
> > The recent changes did not collide with our patches; fairly minor. Tests
still
> > pass and suggestions run quickly.
> > 
> > One thing to note is that COPYING{.LGPL->.LESSER} changed to v3. This
appears
> to
> > me to be ok since everything I read says, "or later", but note that the
> > individual files (*.cxx,hxx) still have the older license inlined.
> 
> LGTM with caveat that you should double-check licensing w/ pcounsel

Hunspell integrated the array bounds fix and cut a new version, so I just
sync'd to that version. This way, google.patch stays simpler, and it should
be easier to figure out the latest diff for the next update.

I think all it needs is a quick look-over, esp. README.chromium.

[groby-ooo-7-16, 2017-01-11 17:57:49]

On 2017/01/06 15:14:42, Kevin Bailey wrote:
> On 2016/12/23 00:27:40, groby wrote:
> > On 2016/12/20 20:36:46, Kevin Bailey wrote:
> > > The recent changes did not collide with our patches; fairly minor. Tests
> still
> > > pass and suggestions run quickly.
> > > 
> > > One thing to note is that COPYING{.LGPL->.LESSER} changed to v3. This
> appears
> > to
> > > me to be ok since everything I read says, "or later", but note that the
> > > individual files (*.cxx,hxx) still have the older license inlined.
> > 
> > LGTM with caveat that you should double-check licensing w/ pcounsel
> 
> Hunspell integrated the array bounds fix and cut a new version, so I just
> sync'd to that version. This way, google.patch stays simpler, and it should
> be easier to figure out the latest diff for the next update.
> 
> I think all it needs is a quick look-over, esp. README.chromium.

Two nits, and I'd add something like "license change vetted" to the description.
Just in case the next person maintaining this ever wonders :)

[Kevin Bailey, 2017-01-11 18:05:19]

Description was changed from

==========
[spellcheck] Updated Hunspell to 1.6.0

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

BUG=673424
==========

to

==========
[spellcheck] Updated Hunspell to 1.6.0

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

The license requirements were approved, by having README.chromium
specify which license it was using.

BUG=673424
==========

[Kevin Bailey, 2017-01-11 18:06:30]

Updated issue description, and passing Windows bots (yay) but
I'm not seeing the nits.

[groby-ooo-7-16, 2017-01-11 18:40:12]

Sigh. "Reply" doesn't send pending messages, sorry. Here you go.

https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/RE...
File third_party/hunspell/README.chromium (right):

https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/RE...
third_party/hunspell/README.chromium:10: * Move README.md onto the README
symlink.
Well, since you said Windows doesn't like symlinks... You might want to fix this
:)

https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/RE...
third_party/hunspell/README.chromium:34: 4) Generate the updated patch:
Did you generate the updated patch?

[Kevin Bailey, 2017-01-11 19:10:51]

https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/RE...
File third_party/hunspell/README.chromium (right):

https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/RE...
third_party/hunspell/README.chromium:10: * Move README.md onto the README
symlink.
On 2017/01/11 18:40:12, groby wrote:
> Well, since you said Windows doesn't like symlinks... You might want to fix
this
> :)

Not sure if you're looking at an old snapshot, but README.md is gone and README
is text again. The Windows bots are happy again.

https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/RE...
third_party/hunspell/README.chromium:34: 4) Generate the updated patch:
On 2017/01/11 18:40:12, groby wrote:
> Did you generate the updated patch?

Ya, the patch has the latest, which is even less than before, since they've
integrated all the recent changes.

One thing missing is the clobbering of the symlink. 'patch' handling of symlinks
is unclear. (There's an option to help it along, but it's deprecated.)

[groby-ooo-7-16, 2017-01-12 02:38:53]

On 2017/01/11 19:10:51, Kevin Bailey wrote:
>
https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/RE...
> File third_party/hunspell/README.chromium (right):
> 
>
https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/RE...
> third_party/hunspell/README.chromium:10: * Move README.md onto the README
> symlink.
> On 2017/01/11 18:40:12, groby wrote:
> > Well, since you said Windows doesn't like symlinks... You might want to fix
> this
> > :)
> 
> Not sure if you're looking at an old snapshot, but README.md is gone and
README
> is text again. The Windows bots are happy again.
> 
>
https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/RE...
> third_party/hunspell/README.chromium:34: 4) Generate the updated patch:
> On 2017/01/11 18:40:12, groby wrote:
> > Did you generate the updated patch?
> 
> Ya, the patch has the latest, which is even less than before, since they've
> integrated all the recent changes.
> 
> One thing missing is the clobbering of the symlink. 'patch' handling of
symlinks
> is unclear. (There's an option to help it along, but it's deprecated.)

We can probably handle the symlink separately. LGTM

[Kevin Bailey, 2017-01-12 14:09:32]

The CQ bit was checked by krb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 14:09:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 14:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 14:16:48]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Kevin Bailey, 2017-01-12 14:42:59]

The CQ bit was checked by krb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 14:43:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 15:21:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:21:15]

Dry run: This issue passed the CQ dry run.

[Kevin Bailey, 2017-01-12 15:25:15]

The CQ bit was checked by krb@chromium.org

[Kevin Bailey, 2017-01-12 15:25:15]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/2587363003/#ps110001
(title: "Handled presubmit warnings")

[commit-bot: I haz the power, 2017-01-12 15:25:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 15:31:21]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1484234715403360,
"parent_rev": "8733eb80974a809a19c16535bfd39c867845acab", "commit_rev":
"ba36291731404cfa22b167b3b9b318e1f4bb148f"}

[commit-bot: I haz the power, 2017-01-12 15:31:50]

Description was changed from

==========
[spellcheck] Updated Hunspell to 1.6.0

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

The license requirements were approved, by having README.chromium
specify which license it was using.

BUG=673424
==========

to

==========
[spellcheck] Updated Hunspell to 1.6.0

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

The license requirements were approved, by having README.chromium
specify which license it was using.

BUG=673424

Review-Url: https://codereview.chromium.org/2587363003
Cr-Commit-Position: refs/heads/master@{#443234}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba36291731404cfa22b167b3b9b3...
==========

[commit-bot: I haz the power, 2017-01-12 15:31:51]

Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/ba36291731404cfa22b167b3b9b3...

[Kevin Bailey, 2017-01-12 15:34:22]

Description was changed from

==========
[spellcheck] Updated Hunspell to 1.6.0

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

The license requirements were approved, by having README.chromium
specify which license it was using.

BUG=673424

Review-Url: https://codereview.chromium.org/2587363003
Cr-Commit-Position: refs/heads/master@{#443234}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba36291731404cfa22b167b3b9b3...
==========

to

==========
[spellcheck] Updated Hunspell to 1.6.0

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

The license requirements were approved, by having README.chromium
specify which license it was using.

To provide more history: We noticed 2 problems with the latest version of
Hunspell (circa 1.5.3 ?). One was that a fuzzer test was complaining about
reading (?) off the end of an array. The other was that unit tests would many
times fail due to time-out. Specifically, that generating suggestions was taking
too long.

I tracked down both issues and submitted patches to the project. Initially I was
simply going to make 2 CLs for the issues, but Hunspell integrated the fixes
quickly and cut 1.6.0, so I just grabbed that. 

Technically, they didn't take my conservative fuzzer fix, but instead made a
more targetted one. Also, they made some additional optimizations.

In case it helps someone, we are now sync'd to github hash
2ef84638b8da4c4229242b98fb67131ece334e09.

BUG=673424
==========

[groby-ooo-7-16, 2017-02-15 01:40:40]

On 2017/01/12 15:31:51, commit-bot: I haz the power wrote:
> Committed patchset #7 (id:110001) as
>
https://chromium.googlesource.com/chromium/src/+/ba36291731404cfa22b167b3b9b3...

Closing this issue - oddly codereview considers it still open.