Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2587363003: [spellcheck] Updated Hunspell to 1.6.0 (Closed)

Created:
4 years ago by Kevin Bailey
Modified:
3 years, 10 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[spellcheck] Updated Hunspell to 1.6.0 To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes. The license requirements were approved, by having README.chromium specify which license it was using. To provide more history: We noticed 2 problems with the latest version of Hunspell (circa 1.5.3 ?). One was that a fuzzer test was complaining about reading (?) off the end of an array. The other was that unit tests would many times fail due to time-out. Specifically, that generating suggestions was taking too long. I tracked down both issues and submitted patches to the project. Initially I was simply going to make 2 CLs for the issues, but Hunspell integrated the fixes quickly and cut 1.6.0, so I just grabbed that. Technically, they didn't take my conservative fuzzer fix, but instead made a more targetted one. Also, they made some additional optimizations. In case it helps someone, we are now sync'd to github hash 2ef84638b8da4c4229242b98fb67131ece334e09. BUG=673424

Patch Set 1 #

Patch Set 2 : Pulled in another optimization #

Patch Set 3 : Update to 1.6.0 #

Patch Set 4 : Updated README.chromium #

Patch Set 5 : Fix README symlink #

Total comments: 4

Patch Set 6 : Fixed last minute differences #

Patch Set 7 : Handled presubmit warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1256 lines, -1018 lines) Patch
M third_party/hunspell/COPYING View 6 1 chunk +674 lines, -12 lines 0 comments Download
A third_party/hunspell/COPYING.LESSER View 6 1 chunk +165 lines, -0 lines 0 comments Download
D third_party/hunspell/COPYING.LGPL View 6 1 chunk +0 lines, -515 lines 0 comments Download
M third_party/hunspell/README View 1 2 3 4 5 6 3 chunks +77 lines, -74 lines 0 comments Download
M third_party/hunspell/README.chromium View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/hunspell/google.patch View 1 2 3 4 5 6 40 chunks +98 lines, -128 lines 0 comments Download
D third_party/hunspell/src/hunspell/README View 6 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/hunspell/src/hunspell/affixmgr.cxx View 6 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/hunspell/src/hunspell/hunspell.hxx View 1 6 1 chunk +5 lines, -2 lines 0 comments Download
D third_party/hunspell/src/hunspell/license.hunspell View 1 2 6 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/hunspell/src/hunspell/license.myspell View 1 2 6 1 chunk +0 lines, -61 lines 0 comments Download
M third_party/hunspell/src/hunspell/suggestmgr.hxx View 6 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/hunspell/src/hunspell/suggestmgr.cxx View 1 6 15 chunks +226 lines, -137 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
Kevin Bailey
The recent changes did not collide with our patches; fairly minor. Tests still pass and ...
4 years ago (2016-12-20 20:36:46 UTC) #3
groby-ooo-7-16
On 2016/12/20 20:36:46, Kevin Bailey wrote: > The recent changes did not collide with our ...
4 years ago (2016-12-23 00:27:40 UTC) #4
Kevin Bailey
On 2016/12/23 00:27:40, groby wrote: > On 2016/12/20 20:36:46, Kevin Bailey wrote: > > The ...
3 years, 11 months ago (2017-01-06 15:14:42 UTC) #6
groby-ooo-7-16
On 2017/01/06 15:14:42, Kevin Bailey wrote: > On 2016/12/23 00:27:40, groby wrote: > > On ...
3 years, 11 months ago (2017-01-11 17:57:49 UTC) #7
Kevin Bailey
Updated issue description, and passing Windows bots (yay) but I'm not seeing the nits.
3 years, 11 months ago (2017-01-11 18:06:30 UTC) #9
groby-ooo-7-16
Sigh. "Reply" doesn't send pending messages, sorry. Here you go. https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/README.chromium File third_party/hunspell/README.chromium (right): https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/README.chromium#newcode10 ...
3 years, 11 months ago (2017-01-11 18:40:12 UTC) #10
Kevin Bailey
https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/README.chromium File third_party/hunspell/README.chromium (right): https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/README.chromium#newcode10 third_party/hunspell/README.chromium:10: * Move README.md onto the README symlink. On 2017/01/11 ...
3 years, 11 months ago (2017-01-11 19:10:51 UTC) #11
groby-ooo-7-16
On 2017/01/11 19:10:51, Kevin Bailey wrote: > https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/README.chromium > File third_party/hunspell/README.chromium (right): > > https://codereview.chromium.org/2587363003/diff/80001/third_party/hunspell/README.chromium#newcode10 ...
3 years, 11 months ago (2017-01-12 02:38:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587363003/110001
3 years, 11 months ago (2017-01-12 15:25:45 UTC) #23
commit-bot: I haz the power
Committed patchset #7 (id:110001) as https://chromium.googlesource.com/chromium/src/+/ba36291731404cfa22b167b3b9b318e1f4bb148f
3 years, 11 months ago (2017-01-12 15:31:51 UTC) #26
groby-ooo-7-16
3 years, 10 months ago (2017-02-15 01:40:40 UTC) #28
On 2017/01/12 15:31:51, commit-bot: I haz the power wrote:
> Committed patchset #7 (id:110001) as
>
https://chromium.googlesource.com/chromium/src/+/ba36291731404cfa22b167b3b9b3...

Closing this issue - oddly codereview considers it still open.

Powered by Google App Engine
This is Rietveld 408576698