Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2587343005: Revert "[Sync] Actively guard against provider being cleared in DeviceInfoSyncBridge." (Closed)

Created:
4 years ago by skym
Modified:
4 years ago
Reviewers:
cdavid1
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert "[Sync] Actively guard against provider being cleared in DeviceInfoSyncBridge." This reverts commit b3d4540a88c89ed2232defdf55aacb62c35b3088. BUG=676194 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2587343005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -76 lines) Patch
M components/sync/device_info/device_info_sync_bridge.cc View 6 chunks +3 lines, -26 lines 0 comments Download
M components/sync/device_info/device_info_sync_bridge_unittest.cc View 5 chunks +0 lines, -50 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
skym
4 years ago (2016-12-21 02:06:06 UTC) #1
skym
TBR maxbogue@ since this is just a revert.
4 years ago (2016-12-21 02:10:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587343005/1
4 years ago (2016-12-21 02:11:08 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-21 02:11:09 UTC) #8
cdavid1
On 2016/12/21 02:11:09, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years ago (2016-12-21 02:14:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587343005/1
4 years ago (2016-12-21 02:21:15 UTC) #11
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years ago (2016-12-21 02:21:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587343005/1
4 years ago (2016-12-21 02:23:56 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-21 02:28:45 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698