Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2587343002: Reland of load: "Request desktop site" feature should ask reposting (Closed)

Created:
4 years ago by yoichio
Modified:
4 years ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, Charlie Reis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of load: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2593533002/ ) Reason for revert: This is not culprit Original issue's description: > Revert of Reload: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2587923002/ ) > > Reason for revert: > Caused browser_test failure: > https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/36770 > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/34179 > https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25740 > https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/36090 > > Original issue's description: > > Reload: "Request desktop site" feature should ask reposting > > > > Now Android Chrome does not confirm if it is expected to repost a form > > on selecting "Request desktop site". > > > > This change modifies to ask it as we do in other cases. > > > > If a user reject reposting, the navigation switches to use desktop user > > agent strings as usuals, but only for the next navigation and > > following ones. > > > > BUG=675522 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > > > Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704 > > Cr-Commit-Position: refs/heads/master@{#439727} > > TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=675522 > > Committed: https://crrev.com/28ed9ea575ab0cfb7db84ab0132863b3fa22cb4d > Cr-Commit-Position: refs/heads/master@{#439749} TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=675522 Committed: https://crrev.com/4f7be0c112fbe3bb4c68436eaafe7ba0ff48a5e0 Cr-Commit-Position: refs/heads/master@{#439751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/frame_host/navigation_controller_android.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
yoichio
Created Reland of load: "Request desktop site" feature should ask reposting
4 years ago (2016-12-20 08:26:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587343002/1
4 years ago (2016-12-20 08:26:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 08:28:10 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-20 08:31:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f7be0c112fbe3bb4c68436eaafe7ba0ff48a5e0
Cr-Commit-Position: refs/heads/master@{#439751}

Powered by Google App Engine
This is Rietveld 408576698