Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2587323002: FrameLoader: remove a TODO and add a comment (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FrameLoader: remove a TODO and add a comment Remove a TODO that I left before because I confirmed that current code is correct, and chaging it makes many unit tests fail. BUG=670232 Committed: https://crrev.com/0299ae01c9ecd229d991d899bff694232a0ea579 Cr-Commit-Position: refs/heads/master@{#439807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Takashi Toyoshima
ptal
4 years ago (2016-12-20 07:29:23 UTC) #3
yhirano
lgtm
4 years ago (2016-12-20 12:10:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587323002/1
4 years ago (2016-12-20 13:48:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 15:23:04 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 15:24:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0299ae01c9ecd229d991d899bff694232a0ea579
Cr-Commit-Position: refs/heads/master@{#439807}

Powered by Google App Engine
This is Rietveld 408576698