Update WebVR feature statues so tests can run without command line flags.

Update WebVR feature status so tests can run without command line flags.

BUG=675766
Committed: https://crrev.com/6e9b665dd6476e5fbb31439c6089d755dd964f54
Cr-Commit-Position: refs/heads/master@{#439977}

[amp, 2016-12-19 23:16:07]

amp@chromium.org changed reviewers:
+ bsheedy@chromium.org, haraken@chromium.org

[amp, 2016-12-19 23:16:07]

bsheedy please verify this is the correct status for what the tests need.

haraken please OWNERS review for platform.

Thanks!

[bsheedy, 2016-12-19 23:17:04]

LGTM

[haraken, 2016-12-20 00:16:01]

LGTM

[amp, 2016-12-20 00:17:08]

The CQ bit was checked by amp@chromium.org

[commit-bot: I haz the power, 2016-12-20 00:17:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 01:46:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 01:46:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[bsheedy, 2016-12-20 01:53:52]

Those failures (or rather, unexpected passes) don't look related to WebVR at
all, although you never know. Might want to try again and see if it's a flaky
test.

[amp, 2016-12-20 03:59:12]

The CQ bit was checked by amp@chromium.org

[commit-bot: I haz the power, 2016-12-20 03:59:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amp, 2016-12-20 03:59:50]

Description was changed from

==========
Update WebVR feature statues so tests can run without command line flags.

BUG=675766
==========

to

==========
Update WebVR feature status so tests can run without command line flags.

BUG=675766
==========

[commit-bot: I haz the power, 2016-12-20 05:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 05:45:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[amp, 2016-12-20 18:05:56]

The CQ bit was checked by amp@chromium.org

[amp, 2016-12-20 18:05:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
bsheedy@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2587223003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-20 18:06:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 19:42:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 19:42:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bsheedy, 2016-12-20 19:53:37]

I lied, there are three tests that seem to be picking up WebVR's IDLs:

1.
imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions.html
2. virtual/mojo-loading/webexposed/global-interface-listing.html
3. webexposed/global-interface-listing.html

I believe you should be able to fix this just by running the tests locally and
updating their expectation files:

1.
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/...
2. Can't find file - maybe uses the one below as well? Or maybe haraken@ knows
more?
3.
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/webexpose...

[amp, 2016-12-20 19:54:19]

On 2016/12/20 19:42:14, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

CQ is still failing for non-obvious reasons that don't appear related to this
change.

I'll wait a bit more and see if it clears up later today or tomorrow.

[amp, 2016-12-20 19:55:59]

On 2016/12/20 19:54:19, amp wrote:
> On 2016/12/20 19:42:14, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> CQ is still failing for non-obvious reasons that don't appear related to this
> change.
> 
> I'll wait a bit more and see if it clears up later today or tomorrow.

[amp, 2016-12-20 19:58:07]

On 2016/12/20 19:53:37, bsheedy wrote:
> I lied, there are three tests that seem to be picking up WebVR's IDLs:
> 
> 1.
>
imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions.html
> 2. virtual/mojo-loading/webexposed/global-interface-listing.html
> 3. webexposed/global-interface-listing.html
> 
> I believe you should be able to fix this just by running the tests locally and
> updating their expectation files:
> 
> 1.
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/...
> 2. Can't find file - maybe uses the one below as well? Or maybe haraken@ knows
> more?
> 3.
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/webexpose...

Ah, thanks for figuring that out.  I tried looking into it, but couldn't figure
out what was going on.

Will the tests that should fail but passed be an issue?

[bsheedy, 2016-12-20 20:00:32]

On 2016/12/20 19:58:07, amp wrote:
> On 2016/12/20 19:53:37, bsheedy wrote:
> > I lied, there are three tests that seem to be picking up WebVR's IDLs:
> > 
> > 1.
> >
>
imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions.html
> > 2. virtual/mojo-loading/webexposed/global-interface-listing.html
> > 3. webexposed/global-interface-listing.html
> > 
> > I believe you should be able to fix this just by running the tests locally
and
> > updating their expectation files:
> > 
> > 1.
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/...
> > 2. Can't find file - maybe uses the one below as well? Or maybe haraken@
knows
> > more?
> > 3.
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/webexpose...
> 
> Ah, thanks for figuring that out.  I tried looking into it, but couldn't
figure
> out what was going on.
> 
> Will the tests that should fail but passed be an issue?

I don't think so - looking at the retry without the patch, it only retries the 3
unexpected failures and doesn't mention anything about the unexpected passes.

[bsheedy, 2016-12-20 20:00:32]

On 2016/12/20 19:58:07, amp wrote:
> On 2016/12/20 19:53:37, bsheedy wrote:
> > I lied, there are three tests that seem to be picking up WebVR's IDLs:
> > 
> > 1.
> >
>
imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions.html
> > 2. virtual/mojo-loading/webexposed/global-interface-listing.html
> > 3. webexposed/global-interface-listing.html
> > 
> > I believe you should be able to fix this just by running the tests locally
and
> > updating their expectation files:
> > 
> > 1.
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/...
> > 2. Can't find file - maybe uses the one below as well? Or maybe haraken@
knows
> > more?
> > 3.
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/webexpose...
> 
> Ah, thanks for figuring that out.  I tried looking into it, but couldn't
figure
> out what was going on.
> 
> Will the tests that should fail but passed be an issue?

I don't think so - looking at the retry without the patch, it only retries the 3
unexpected failures and doesn't mention anything about the unexpected passes.

[amp, 2016-12-21 00:01:05]

The CQ bit was checked by amp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:01:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:04:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:04:57]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[amp, 2016-12-21 00:13:24]

The CQ bit was checked by amp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:13:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 01:55:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 01:55:29]

Dry run: This issue passed the CQ dry run.

[amp, 2016-12-21 01:57:16]

The CQ bit was checked by amp@chromium.org

[amp, 2016-12-21 01:57:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
bsheedy@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2587223003/#ps60001
(title: "fix merge conflict with test expectations")

[commit-bot: I haz the power, 2016-12-21 01:57:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 02:04:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482285436836620,
"parent_rev": "3094a0e7bfda1f282608b7ab0e36386d74c95f17", "commit_rev":
"6bd8973242260238b82b264202e8dcfbc17fb846"}

[commit-bot: I haz the power, 2016-12-21 02:04:38]

Description was changed from

==========
Update WebVR feature status so tests can run without command line flags.

BUG=675766
==========

to

==========
Update WebVR feature status so tests can run without command line flags.

BUG=675766

Review-Url: https://codereview.chromium.org/2587223003
==========

[commit-bot: I haz the power, 2016-12-21 02:04:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-21 02:07:04]

Description was changed from

==========
Update WebVR feature status so tests can run without command line flags.

BUG=675766

Review-Url: https://codereview.chromium.org/2587223003
==========

to

==========
Update WebVR feature status so tests can run without command line flags.

BUG=675766

Committed: https://crrev.com/6e9b665dd6476e5fbb31439c6089d755dd964f54
Cr-Commit-Position: refs/heads/master@{#439977}
==========

[commit-bot: I haz the power, 2016-12-21 02:07:06]

Patchset 4 (id:??) landed as
https://crrev.com/6e9b665dd6476e5fbb31439c6089d755dd964f54
Cr-Commit-Position: refs/heads/master@{#439977}