Correct handling of cross-frame functions in ddc.

Correct handling of cross-frame functions in ddc.
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/7f26211c266e37731bfc42b1b7cee53c25f99496

[Jacob, 2016-12-19 21:56:35]

jacobr@google.com changed reviewers:
+ alanknight@google.com, leafp@google.com, rnystrom@google.com

[Jacob, 2016-12-19 21:56:35]

alanknight for the html "fixes"
rnystrom for the test fixes
leafp or rnystrom for everything else.

[Jacob, 2016-12-19 21:57:46]

fyi chatted with Jen briefly before she left Friday and she agreed using typeof
for is Function checks was generally reasonable.

[Bob Nystrom, 2016-12-19 22:23:42]

One thing then test stuff LGTM!

https://codereview.chromium.org/2587203002/diff/1/pkg/dev_compiler/test/brows...
File pkg/dev_compiler/test/browser/language_tests.js (right):

https://codereview.chromium.org/2587203002/diff/1/pkg/dev_compiler/test/brows...
pkg/dev_compiler/test/browser/language_tests.js:474: // 'js_test': 'fail',
Just delete the line.

[Alan Knight, 2016-12-19 22:35:45]

lgtm

[Jacob, 2016-12-19 22:38:14]

https://codereview.chromium.org/2587203002/diff/1/pkg/dev_compiler/test/brows...
File pkg/dev_compiler/test/browser/language_tests.js (right):

https://codereview.chromium.org/2587203002/diff/1/pkg/dev_compiler/test/brows...
pkg/dev_compiler/test/browser/language_tests.js:474: // 'js_test': 'fail',
On 2016/12/19 22:23:42, Bob Nystrom wrote:
> Just delete the line.
doh. done.

[Leaf, 2016-12-19 22:42:57]

https://codereview.chromium.org/2587203002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2587203002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:937: '#.is = function
is_Function(o) { return typeof o == "function"; }',
Does this do the right thing for classes with call methods?

[Jacob, 2016-12-19 22:53:33]

https://codereview.chromium.org/2587203002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2587203002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:937: '#.is = function
is_Function(o) { return typeof o == "function"; }',
On 2016/12/19 22:42:56, Leaf wrote:
> Does this do the right thing for classes with call methods?

Yes because classes with call methods have to be implemented
by a function object with a mangled prototype as that is the
only way to make a callable object in JS and DDC calling
conventions mean that all functions have to be called like regular JS functions.

[Leaf, 2016-12-19 22:55:20]

lgtm

[Jacob, 2016-12-19 23:01:04]

Description was changed from

==========
Correct handling of cross-frame functions in ddc.
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes
https://github.com/dart-lang/sdk/issues/26197)

BUG=
==========

to

==========
Correct handling of cross-frame functions in ddc.
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes
https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7f26211c266e37731bfc42b1b7cee53c25f99496
==========

[Jacob, 2016-12-19 23:01:05]

Committed patchset #2 (id:20001) manually as
7f26211c266e37731bfc42b1b7cee53c25f99496 (presubmit successful).