Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: tools/dom/templates/html/impl/impl_Blob.darttemplate

Issue 2587203002: Correct handling of cross-frame functions in ddc. (Closed)
Patch Set: Fix bug in Blob creation from workers. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of $LIBRARYNAME; 5 part of $LIBRARYNAME;
6 6
7 $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS { 7 $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS {
8 $!MEMBERS 8 $!MEMBERS
9 $if DART2JS 9 $if DART2JS
10 factory Blob(List blobParts, [String type, String endings]) { 10 factory Blob(List blobParts, [String type, String endings]) {
11 // TODO: validate that blobParts is a JS Array and convert if not. 11 // TODO: validate that blobParts is a JS Array and convert if not.
12 // TODO: any coercions on the elements of blobParts, e.g. coerce a typed 12 // TODO: any coercions on the elements of blobParts, e.g. coerce a typed
13 // array to ArrayBuffer if it is a total view. 13 // array to ArrayBuffer if it is a total view.
14 if (type == null && endings == null) { 14 if (type == null && endings == null) {
15 return _create_1(blobParts); 15 return _create_1(blobParts);
16 } 16 }
17 var bag = _create_bag(); 17 var bag = _create_bag();
18 if (type != null) _bag_set(bag, 'type', type); 18 if (type != null) _bag_set(bag, 'type', type);
19 if (endings != null) _bag_set(bag, 'endings', endings); 19 if (endings != null) _bag_set(bag, 'endings', endings);
20 return _create_2(blobParts, bag); 20 return _create_2(blobParts, bag);
21 } 21 }
22 22
23 static _create_1(parts) => JS('Blob', 'new window.Blob(#)', parts); 23 static _create_1(parts) => JS('Blob', 'new self.Blob(#)', parts);
24 static _create_2(parts, bag) => JS('Blob', 'new window.Blob(#, #)', parts, bag ); 24 static _create_2(parts, bag) => JS('Blob', 'new self.Blob(#, #)', parts, bag);
25 25
26 static _create_bag() => JS('var', '{}'); 26 static _create_bag() => JS('var', '{}');
27 static _bag_set(bag, key, value) { JS('void', '#[#] = #', bag, key, value); } 27 static _bag_set(bag, key, value) { JS('void', '#[#] = #', bag, key, value); }
28 $else 28 $else
29 $if JSINTEROP 29 $if JSINTEROP
30 factory Blob(List blobParts, [String type, String endings]) { 30 factory Blob(List blobParts, [String type, String endings]) {
31 // TODO: any coercions on the elements of blobParts, e.g. coerce a typed 31 // TODO: any coercions on the elements of blobParts, e.g. coerce a typed
32 // array to ArrayBuffer if it is a total view. 32 // array to ArrayBuffer if it is a total view.
33 33
34 var parts = convertDartToNative_List(blobParts); 34 var parts = convertDartToNative_List(blobParts);
35 if (type == null && endings == null) { 35 if (type == null && endings == null) {
36 return _blink.BlinkBlob.instance.constructorCallback_1_(parts); 36 return _blink.BlinkBlob.instance.constructorCallback_1_(parts);
37 } 37 }
38 var bag = {}; 38 var bag = {};
39 if (type != null) bag['type'] = type; 39 if (type != null) bag['type'] = type;
40 if (endings != null) bag['endings'] = endings; 40 if (endings != null) bag['endings'] = endings;
41 return _blink.BlinkBlob.instance.constructorCallback_2_(parts, 41 return _blink.BlinkBlob.instance.constructorCallback_2_(parts,
42 convertDartToNative_Dictionary(bag)); 42 convertDartToNative_Dictionary(bag));
43 } 43 }
44 $endif 44 $endif
45 $endif 45 $endif
46 } 46 }
OLDNEW
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698