ios/build/bots/chromium.mac/ios-device.json - Issue 2587123002: Build //ios:all and its dependencies on the iOS builders.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/build/bots/chromium.mac/ios-device.json

Issue 2587123002: Build //ios:all and its dependencies on the iOS builders. (Closed)

Patch Set: Address comments & add mapping to testing/buildbot/gn_isolate_map.pyl. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 "owners": [	2 "owners": [

3 "dpranke",	3 "dpranke",

4 "smut"	4 "smut"

5 ],	5 ],

6 "comments": [	6 "comments": [

7 "Builder for 32-bit devices.",	7 "Builder for 32-bit devices.",

8 "Build is performed with gn+ninja."	8 "Build is performed with gn+ninja."

9 ],	9 ],

10 "xcode version": "8.0",	10 "xcode version": "8.0",

11 "gn_args": [	11 "gn_args": [

12 "additional_target_cpus=[ \"arm64\" ]",	12 "additional_target_cpus=[ \"arm64\" ]",

13 "goma_dir=\"$(goma_dir)\"",	13 "goma_dir=\"$(goma_dir)\"",

14 "ios_enable_code_signing=false",	14 "ios_enable_code_signing=false",

15 "is_component_build=false",	15 "is_component_build=false",

16 "is_debug=true",	16 "is_debug=true",

17 "target_cpu=\"arm\"",	17 "target_cpu=\"arm\"",

18 "target_os=\"ios\"",	18 "target_os=\"ios\"",

19 "use_goma=true"	19 "use_goma=true"

20 ],	20 ],

	21 "additional_compile_targets": [

	22 "ios:all"

	23 ],

21 "compiler": "ninja",	24 "compiler": "ninja",

22 "configuration": "Release",	25 "configuration": "Release",

23 "sdk": "iphoneos10.0",	26 "sdk": "iphoneos10.0",

24 "tests": [	27 "tests": [

25 ]	28 ]

26 }	29 }

OLD	NEW