Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2587073004: RootLayerScrolling: Fix TableCellPainterTest (Closed)

Created:
4 years ago by szager1
Modified:
4 years ago
Reviewers:
pdr., skobes
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RootLayerScrolling: Fix TableCellPainterTest Previously, the updated test would overflow the frame. This caused the test assertions to fails because when RLS is enabled and the frame overflows, the scrolling contents are painted into the scrolling contents layer of the LayoutView's CompositedLayerMapping. This change just ensures that the test doesn't overflow the frame. BUG=490942 R=skobes@chromium.org,pdr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/5f4e7a7530804ce781666eac58fd3977b84cbfc3 Cr-Commit-Position: refs/heads/master@{#439658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
szager1
4 years ago (2016-12-19 23:10:58 UTC) #1
pdr.
LGTM because this test is unrelated to scrolling, though I think the core issue (different ...
4 years ago (2016-12-19 23:13:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587073004/1
4 years ago (2016-12-19 23:37:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 01:43:43 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 01:46:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f4e7a7530804ce781666eac58fd3977b84cbfc3
Cr-Commit-Position: refs/heads/master@{#439658}

Powered by Google App Engine
This is Rietveld 408576698