Forbid storing objects in new space in Code header

Forbid storing objects in new space in Code header

If you try to store an object in new space to the Code header, it will
be added to the store buffer, and a DCHECK will fail later, since Code
objects should never occur in the store buffer.

This CL adds DCHECKs to catch such assignments early. Once we handle
this case better, they can be removed again.

R=mstarzinger@chromium.org, ulan@chromium.org
BUG=chromium:674535
Review-Url: https://codereview.chromium.org/2587073002
Cr-Commit-Position: refs/heads/master@{#42142}
Committed: https://chromium.googlesource.com/v8/v8/+/02ae44b77d37b1c2828cd1ab2ee7644b6d047338

[Clemens Hammacher, 2016-12-19 17:03:49]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 17:04:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-19 17:33:05]

Description was changed from

==========
Forbid storing objects in new space in Code header

If you try to store an object in new space to the Code header, it will
be added to the store buffer, and a DCHECK will fail later, since Code
objects should never occur in the store buffer.

This CL adds DCHECKs to catch such assignments early.

R=mstarzinger@chromium.org, ulan@chromium.org
BUG=chromium:674535
==========

to

==========
Forbid storing objects in new space in Code header

If you try to store an object in new space to the Code header, it will
be added to the store buffer, and a DCHECK will fail later, since Code
objects should never occur in the store buffer.

This CL adds DCHECKs to catch such assignments early. Once we handle
this case better, they can be removed again.

R=mstarzinger@chromium.org, ulan@chromium.org
BUG=chromium:674535
==========

[commit-bot: I haz the power, 2016-12-19 17:33:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 17:33:09]

Dry run: This issue passed the CQ dry run.

[ulan, 2016-12-21 14:46:37]

LGTM

[Michael Starzinger, 2017-01-09 13:31:08]

LGTM.

[Clemens Hammacher, 2017-01-09 13:31:24]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2017-01-09 13:31:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 13:58:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483968684123620, "parent_rev":
"7ed3c4d791b3f67cdf582e83dc9e04baf8bed562", "commit_rev":
"02ae44b77d37b1c2828cd1ab2ee7644b6d047338"}

[commit-bot: I haz the power, 2017-01-09 13:58:45]

Description was changed from

==========
Forbid storing objects in new space in Code header

If you try to store an object in new space to the Code header, it will
be added to the store buffer, and a DCHECK will fail later, since Code
objects should never occur in the store buffer.

This CL adds DCHECKs to catch such assignments early. Once we handle
this case better, they can be removed again.

R=mstarzinger@chromium.org, ulan@chromium.org
BUG=chromium:674535
==========

to

==========
Forbid storing objects in new space in Code header

If you try to store an object in new space to the Code header, it will
be added to the store buffer, and a DCHECK will fail later, since Code
objects should never occur in the store buffer.

This CL adds DCHECKs to catch such assignments early. Once we handle
this case better, they can be removed again.

R=mstarzinger@chromium.org, ulan@chromium.org
BUG=chromium:674535

Review-Url: https://codereview.chromium.org/2587073002
Cr-Commit-Position: refs/heads/master@{#42142}
Committed:
https://chromium.googlesource.com/v8/v8/+/02ae44b77d37b1c2828cd1ab2ee7644b6d0...
==========

[commit-bot: I haz the power, 2017-01-09 13:58:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/02ae44b77d37b1c2828cd1ab2ee7644b6d0...