Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2586993002: Upstream Chrome on iOS source code [3/11]. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, tfarina, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Chrome on iOS source code [3/11]. Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Committed: https://crrev.com/df582f945640bca3dfe7465ad0d5e59581eab08f Cr-Commit-Position: refs/heads/master@{#439460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23700 lines, -0 lines) Patch
A ios/chrome/browser/ui/activity_services/activity_type_util.h View 1 chunk +70 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/activity_type_util.mm View 1 chunk +204 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm View 1 chunk +107 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/appex_constants.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/appex_constants.mm View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h View 1 chunk +48 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/chrome_activity_item_source.mm View 1 chunk +242 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/print_activity.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/print_activity.mm View 1 chunk +73 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/reading_list_activity.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/reading_list_activity.mm View 1 chunk +80 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/share_protocol.h View 1 chunk +79 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/share_to_data.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/share_to_data.mm View 1 chunk +94 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm View 1 chunk +101 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.mm View 1 chunk +237 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/animators/README.md View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/animators/zoom_transition_animator.h View 1 chunk +48 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/animators/zoom_transition_animator.mm View 1 chunk +129 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/animators/zoom_transition_delegate.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/authentication_flow.h View 1 chunk +67 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/authentication_flow.mm View 1 chunk +456 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/authentication_flow_performer.h View 1 chunk +87 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/authentication_flow_performer.mm View 1 chunk +452 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/authentication_flow_performer_delegate.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/authentication_flow_unittest.mm View 1 chunk +303 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/authentication_ui_util.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/authentication_ui_util.mm View 1 chunk +61 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/chrome_signin_view_controller.h View 1 chunk +106 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm View 1 chunk +948 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.h View 1 chunk +62 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.mm View 1 chunk +131 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/re_signin_infobar_delegate_unittest.mm View 1 chunk +218 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm View 1 chunk +393 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller_unittest.mm View 1 chunk +62 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.mm View 1 chunk +332 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm View 1 chunk +393 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signin_interaction_controller.h View 1 chunk +60 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signin_interaction_controller.mm View 1 chunk +374 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm View 1 chunk +600 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/card_unmask_prompt_view_bridge.h View 1 chunk +81 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/card_unmask_prompt_view_bridge.mm View 1 chunk +588 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/cells/cvc_item.h View 1 chunk +85 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/cells/cvc_item.mm View 1 chunk +363 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/cells/cvc_item_unittest.mm View 1 chunk +70 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/cells/status_item.h View 1 chunk +50 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/cells/status_item.mm View 1 chunk +198 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/cells/status_item_unittest.mm View 1 chunk +61 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/cells/storage_switch_item.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/cells/storage_switch_item.mm View 1 chunk +149 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/cells/storage_switch_item_unittest.mm View 1 chunk +56 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/storage_switch_tooltip.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/autofill/storage_switch_tooltip.mm View 1 chunk +70 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.h View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.mm View 1 chunk +252 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bars/bookmark_navigation_bar.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bars/bookmark_navigation_bar.mm View 1 chunk +360 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm View 1 chunk +55 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_all_collection_view.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_all_collection_view.mm View 1 chunk +414 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.h View 1 chunk +97 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.mm View 1 chunk +550 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_collection_view.h View 1 chunk +232 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm View 1 chunk +859 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm View 1 chunk +100 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_controller_factory.mm View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.h View 1 chunk +62 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm View 1 chunk +595 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_elevated_toolbar.mm View 1 chunk +54 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_extended_button.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_extended_button.mm View 1 chunk +74 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm View 1 chunk +474 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.h View 1 chunk +64 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm View 1 chunk +526 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm View 1 chunk +115 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.h View 1 chunk +87 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm View 1 chunk +555 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm View 1 chunk +1180 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_primary_view.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm View 1 chunk +1345 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h View 1 chunk +93 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm View 1 chunk +148 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm View 1 chunk +89 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_home_waiting_view.mm View 1 chunk +79 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.h View 1 chunk +67 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm View 1 chunk +313 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_ios_unittest.h View 1 chunk +44 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_ios_unittest.mm View 1 chunk +48 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_menu_cell.mm View 1 chunk +177 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_menu_item.h View 1 chunk +71 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm View 1 chunk +243 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_menu_view.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_menu_view.mm View 1 chunk +429 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.h View 1 chunk +77 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.mm View 1 chunk +89 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_navigation_controller.h View 1 chunk +13 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_navigation_controller.mm View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_panel_view.h View 1 chunk +62 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_panel_view.mm View 1 chunk +398 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_position_cache.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm View 1 chunk +141 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_position_cache_unittest.mm View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm View 1 chunk +290 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_promo_controller.h View 1 chunk +53 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_promo_controller.mm View 1 chunk +216 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h View 1 chunk +193 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm View 1 chunk +704 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm View 1 chunk +405 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm View 1 chunk +1559 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item.mm View 1 chunk +125 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item_unittest.mm View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-12-19 13:13:57 UTC) #4
rohitrao (ping after 24h)
lgtm!
4 years ago (2016-12-19 13:22:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586993002/1
4 years ago (2016-12-19 13:24:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 13:31:15 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 13:34:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df582f945640bca3dfe7465ad0d5e59581eab08f
Cr-Commit-Position: refs/heads/master@{#439460}

Powered by Google App Engine
This is Rietveld 408576698