Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2586943003: [serializer] do not serialize script wrappers. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
titzer, Mircea Trofin
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] do not serialize script wrappers. The scenario here: the asm function fails asm validation, so we emit a message. In doing so, we create a JSValue wrapper for the script object that we cache on the script object. This wrapper is context-dependent and causes the code serializer to choke. R=mtrofin@chromium.org, titzer@chromium.org BUG=chromium:674446, chromium:673321 Review-Url: https://codereview.chromium.org/2586943003 Cr-Commit-Position: refs/heads/master@{#41794} Committed: https://chromium.googlesource.com/v8/v8/+/07fa0f496788fcca67c21e30064eea6273939b09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/snapshot/code-serializer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/regress/wasm/regression-674447.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Yang
4 years ago (2016-12-19 10:26:49 UTC) #1
titzer
lgtm
4 years ago (2016-12-19 10:29:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586943003/1
4 years ago (2016-12-19 10:44:17 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-19 10:53:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/07fa0f496788fcca67c21e30064eea62739...

Powered by Google App Engine
This is Rietveld 408576698