Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2586883002: binding: Removes dead code in WindowProxy::createContext(). (Closed)

Created:
4 years ago by Yuki
Modified:
4 years ago
Reviewers:
haraken, peria, dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Removes dead code in WindowProxy::createContext(). Per https://crrev.com/2536173002, it seems no need to keep the check at head of WindowProxy::createContext(). http/tests/xsl/xslt-transform-with-javascript-disabled.html passes with this CL. BUG= Committed: https://crrev.com/c20eda8d50867e0378c8997ad0cdb1702950f525 Cr-Commit-Position: refs/heads/master@{#439435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Yuki
haraken@, could you review this CL? R=dcheng@ FYI.
4 years ago (2016-12-19 08:26:41 UTC) #6
peria
lgtm Yay!
4 years ago (2016-12-19 08:28:55 UTC) #8
haraken
LGTM
4 years ago (2016-12-19 08:33:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586883002/1
4 years ago (2016-12-19 08:34:39 UTC) #11
dcheng
LGTM
4 years ago (2016-12-19 08:35:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 08:38:33 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-19 08:41:36 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c20eda8d50867e0378c8997ad0cdb1702950f525
Cr-Commit-Position: refs/heads/master@{#439435}

Powered by Google App Engine
This is Rietveld 408576698