Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2586843002: Fix wrong DCHECK in VaapiVideoDecodeAccelerator (Closed)

Created:
4 years ago by kcwu
Modified:
4 years ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong DCHECK in VaapiVideoDecodeAccelerator We don't need to parse compressed header with vaapi. The callback for context update should always be null. TEST=video_decode_accelerator_unittest with VP9 video on samus BUG=b/33563231 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/7d4d7fe6fbcb817ad942842d41b76de504882644 Cr-Commit-Position: refs/heads/master@{#439715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M media/gpu/vaapi_video_decode_accelerator.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kcwu
Instead of removal, I reverted the DCHECK condition.
4 years ago (2016-12-19 04:25:47 UTC) #3
Pawel Osciak
lgtm
4 years ago (2016-12-20 01:13:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586843002/1
4 years ago (2016-12-20 03:28:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 05:15:55 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 05:21:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d4d7fe6fbcb817ad942842d41b76de504882644
Cr-Commit-Position: refs/heads/master@{#439715}

Powered by Google App Engine
This is Rietveld 408576698