Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2586823002: Fix positions printing in compiler/graph-visualizer.cc. (Closed)

Created:
4 years ago by Vyacheslav Egorov (Google)
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix positions printing in compiler/graph-visualizer.cc. We are printing `inlining(...), pos:offset` where we should print `pos:inlining(...), offset`. BUG= Review-Url: https://codereview.chromium.org/2586823002 Cr-Commit-Position: refs/heads/master@{#41786} Committed: https://chromium.googlesource.com/v8/v8/+/f63f64ca1f9300c857c16041b3eb769a52432bbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/graph-visualizer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Vyacheslav Egorov (Google)
Hi Benedikt, Could you take a look? It's just a simple issue of incorrect formatting.
4 years ago (2016-12-19 00:43:20 UTC) #2
Benedikt Meurer
LGTM.
4 years ago (2016-12-19 04:48:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586823002/1
4 years ago (2016-12-19 08:09:09 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-19 08:34:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f63f64ca1f9300c857c16041b3eb769a524...

Powered by Google App Engine
This is Rietveld 408576698