Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2586713002: Upstream code and resources for Chrome on iOS extensions. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), dcheng, extensions-reviews_chromium.org, Olivier
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream code and resources for Chrome on iOS extensions. Upstream all code and resources for Chrome on iOS today and share extensions. BUG=534433 Committed: https://crrev.com/dab3d5d08a407eaa114feeac75899500da64fc31 Cr-Commit-Position: refs/heads/master@{#439357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4320 lines, -2 lines) Patch
M ios/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/share_extension/BUILD.gn View 2 chunks +69 lines, -0 lines 0 comments Download
A ios/chrome/share_extension/Info.plist View 1 chunk +50 lines, -0 lines 0 comments Download
A ios/chrome/share_extension/entitlements/external/share_extension.appex.entitlements View 1 chunk +12 lines, -0 lines 0 comments Download
A ios/chrome/share_extension/share_extension_localize_strings_config.plist View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/share_extension/share_extension_view.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/share_extension/share_extension_view.mm View 1 chunk +305 lines, -0 lines 0 comments Download
A ios/chrome/share_extension/share_view_controller.h View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/share_extension/share_view_controller.mm View 1 chunk +298 lines, -0 lines 0 comments Download
A ios/chrome/share_extension/ui_util.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/share_extension/ui_util.mm View 1 chunk +29 lines, -0 lines 0 comments Download
M ios/chrome/today_extension/BUILD.gn View 2 chunks +106 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/Info.plist View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/entitlements/external/today_extension.appex.entitlements View 1 chunk +12 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/footer_label.h View 1 chunk +86 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/footer_label.mm View 1 chunk +125 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/interactive_label.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/interactive_label.mm View 1 chunk +269 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/lock_screen_state.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/lock_screen_state.mm View 1 chunk +197 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/notification_center_button.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/notification_center_button.mm View 1 chunk +69 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/notification_center_url_button.h View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/notification_center_url_button.mm View 1 chunk +179 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/physical_web_optin_footer.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/physical_web_optin_footer.mm View 1 chunk +262 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/resources/todayview_clipboard.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_clipboard@2x.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_clipboard@3x.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_new_tab.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_new_tab@2x.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_new_tab@3x.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_physical_web.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_physical_web@2x.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_physical_web@3x.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_voice_search.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_voice_search@2x.png View Binary file 0 comments Download
A ios/chrome/today_extension/resources/todayview_voice_search@3x.png View Binary file 0 comments Download
A ios/chrome/today_extension/today_metrics_logger.h View 1 chunk +76 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/today_metrics_logger.mm View 1 chunk +302 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/today_view_controller.h View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/today_view_controller.mm View 1 chunk +1105 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/transparent_button.h View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/transparent_button.mm View 1 chunk +124 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/ui_util.h View 1 chunk +64 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/ui_util.mm View 1 chunk +124 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/url_table_cell.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/chrome/today_extension/url_table_cell.mm View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
sdefresne
Please take a look.
4 years ago (2016-12-17 19:25:45 UTC) #4
rohitrao (ping after 24h)
Rubberstamp LGTM
4 years ago (2016-12-17 19:26:32 UTC) #5
sdefresne
+olivierrobin FYI
4 years ago (2016-12-17 19:27:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586713002/1
4 years ago (2016-12-17 19:27:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/88326)
4 years ago (2016-12-17 20:57:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586713002/1
4 years ago (2016-12-17 21:13:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/88346)
4 years ago (2016-12-17 22:44:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586713002/1
4 years ago (2016-12-17 23:31:46 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-18 00:06:31 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-18 00:08:15 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dab3d5d08a407eaa114feeac75899500da64fc31
Cr-Commit-Position: refs/heads/master@{#439357}

Powered by Google App Engine
This is Rietveld 408576698