Revert of DevTools: merge array formatting logic

Revert of DevTools: merge array formatting logic (patchset #7 id:120001 of https://codereview.chromium.org/2566443004/ )

Reason for revert:
Console previews for arrays have been compromised.  When logging an array with 100+ non-empty properties, the overflow properties (after the first 100 in the preview) show up as 'undefined x N' when they are not undefined.

Repro case:
var b = new Array(200);
b.fill(2);
console.log(b);

crbug.com/675259

Original issue's description:
> DevTools: merge array formatting logic
>
> This CL makes array formatting consistent and prepares
> RemoteObjectPreviewFormatter (ROPF) to introduce character cutoff logic.
> Today, array formatting is split between two files. The logic in
> ConsoleViewMessage has been folded into ROPF.js with all arrays showing gaps
> with 'undefined x n' as much as possible then falling back to 'key: value'.
>
> For background on character cutoff logic, see C1 in the console preview doc.
>
> BUG=666882
>
> Committed: https://crrev.com/50c41a1483a808a3394581c717a18cf00773877e
> Cr-Commit-Position: refs/heads/master@{#438294}

TBR=lushnikov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675259
Committed: https://crrev.com/631b841680800d7ea174cc898a4f0c5884111b91
Cr-Commit-Position: refs/heads/master@{#439286}

[luoe, 2016-12-16 23:27:16]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-12-16 23:27:16]

Created Revert of DevTools: merge array formatting logic

[commit-bot: I haz the power, 2016-12-16 23:27:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 23:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 23:28:00]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[luoe, 2016-12-16 23:28:28]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 23:29:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2016-12-16 23:29:18]

Description was changed from

==========
Revert of DevTools: merge array formatting logic (patchset #7 id:120001 of
https://codereview.chromium.org/2566443004/ )

Reason for revert:
Console previews for arrays have been compromised.  When logging an array with
100+ non-empty properties, the overflow properties (after the first 100 in the
preview) show up as 'undefined x N' when they are not undefined.

Repro case:
var b = new Array(200);
b.fill(2);
console.log(b);

crbug.com/675259

Original issue's description:
> DevTools: merge array formatting logic
> 
> This CL makes array formatting consistent and prepares
> RemoteObjectPreviewFormatter (ROPF) to introduce character cutoff logic.
> Today, array formatting is split between two files. The logic in
> ConsoleViewMessage has been folded into ROPF.js with all arrays showing gaps
> with 'undefined x n' as much as possible then falling back to 'key: value'.
> 
> For background on character cutoff logic, see C1 in the console preview doc.
> 
> BUG=666882
> 
> Committed: https://crrev.com/50c41a1483a808a3394581c717a18cf00773877e
> Cr-Commit-Position: refs/heads/master@{#438294}

TBR=lushnikov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666882
==========

to

==========
Revert of DevTools: merge array formatting logic (patchset #7 id:120001 of
https://codereview.chromium.org/2566443004/ )

Reason for revert:
Console previews for arrays have been compromised.  When logging an array with
100+ non-empty properties, the overflow properties (after the first 100 in the
preview) show up as 'undefined x N' when they are not undefined.

Repro case:
var b = new Array(200);
b.fill(2);
console.log(b);

crbug.com/675259

Original issue's description:
> DevTools: merge array formatting logic
> 
> This CL makes array formatting consistent and prepares
> RemoteObjectPreviewFormatter (ROPF) to introduce character cutoff logic.
> Today, array formatting is split between two files. The logic in
> ConsoleViewMessage has been folded into ROPF.js with all arrays showing gaps
> with 'undefined x n' as much as possible then falling back to 'key: value'.
> 
> For background on character cutoff logic, see C1 in the console preview doc.
> 
> BUG=666882
> 
> Committed: https://crrev.com/50c41a1483a808a3394581c717a18cf00773877e
> Cr-Commit-Position: refs/heads/master@{#438294}

TBR=lushnikov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675259
==========

[lushnikov, 2016-12-16 23:29:51]

lgtm

[commit-bot: I haz the power, 2016-12-17 01:03:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 01:03:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[luoe, 2016-12-17 01:06:30]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-12-17 01:07:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 02:18:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481936790885330, "parent_rev":
"c68632111a6cc612524a93f99e8d765a626811e9", "commit_rev":
"29a4dcc0699a051115532a22e2d1ca6dcd6fc03f"}

[commit-bot: I haz the power, 2016-12-17 02:19:00]

Description was changed from

==========
Revert of DevTools: merge array formatting logic (patchset #7 id:120001 of
https://codereview.chromium.org/2566443004/ )

Reason for revert:
Console previews for arrays have been compromised.  When logging an array with
100+ non-empty properties, the overflow properties (after the first 100 in the
preview) show up as 'undefined x N' when they are not undefined.

Repro case:
var b = new Array(200);
b.fill(2);
console.log(b);

crbug.com/675259

Original issue's description:
> DevTools: merge array formatting logic
> 
> This CL makes array formatting consistent and prepares
> RemoteObjectPreviewFormatter (ROPF) to introduce character cutoff logic.
> Today, array formatting is split between two files. The logic in
> ConsoleViewMessage has been folded into ROPF.js with all arrays showing gaps
> with 'undefined x n' as much as possible then falling back to 'key: value'.
> 
> For background on character cutoff logic, see C1 in the console preview doc.
> 
> BUG=666882
> 
> Committed: https://crrev.com/50c41a1483a808a3394581c717a18cf00773877e
> Cr-Commit-Position: refs/heads/master@{#438294}

TBR=lushnikov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675259
==========

to

==========
Revert of DevTools: merge array formatting logic (patchset #7 id:120001 of
https://codereview.chromium.org/2566443004/ )

Reason for revert:
Console previews for arrays have been compromised.  When logging an array with
100+ non-empty properties, the overflow properties (after the first 100 in the
preview) show up as 'undefined x N' when they are not undefined.

Repro case:
var b = new Array(200);
b.fill(2);
console.log(b);

crbug.com/675259

Original issue's description:
> DevTools: merge array formatting logic
> 
> This CL makes array formatting consistent and prepares
> RemoteObjectPreviewFormatter (ROPF) to introduce character cutoff logic.
> Today, array formatting is split between two files. The logic in
> ConsoleViewMessage has been folded into ROPF.js with all arrays showing gaps
> with 'undefined x n' as much as possible then falling back to 'key: value'.
> 
> For background on character cutoff logic, see C1 in the console preview doc.
> 
> BUG=666882
> 
> Committed: https://crrev.com/50c41a1483a808a3394581c717a18cf00773877e
> Cr-Commit-Position: refs/heads/master@{#438294}

TBR=lushnikov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675259

Review-Url: https://codereview.chromium.org/2586623002
==========

[commit-bot: I haz the power, 2016-12-17 02:19:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-17 02:22:33]

Description was changed from

==========
Revert of DevTools: merge array formatting logic (patchset #7 id:120001 of
https://codereview.chromium.org/2566443004/ )

Reason for revert:
Console previews for arrays have been compromised.  When logging an array with
100+ non-empty properties, the overflow properties (after the first 100 in the
preview) show up as 'undefined x N' when they are not undefined.

Repro case:
var b = new Array(200);
b.fill(2);
console.log(b);

crbug.com/675259

Original issue's description:
> DevTools: merge array formatting logic
> 
> This CL makes array formatting consistent and prepares
> RemoteObjectPreviewFormatter (ROPF) to introduce character cutoff logic.
> Today, array formatting is split between two files. The logic in
> ConsoleViewMessage has been folded into ROPF.js with all arrays showing gaps
> with 'undefined x n' as much as possible then falling back to 'key: value'.
> 
> For background on character cutoff logic, see C1 in the console preview doc.
> 
> BUG=666882
> 
> Committed: https://crrev.com/50c41a1483a808a3394581c717a18cf00773877e
> Cr-Commit-Position: refs/heads/master@{#438294}

TBR=lushnikov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675259

Review-Url: https://codereview.chromium.org/2586623002
==========

to

==========
Revert of DevTools: merge array formatting logic (patchset #7 id:120001 of
https://codereview.chromium.org/2566443004/ )

Reason for revert:
Console previews for arrays have been compromised.  When logging an array with
100+ non-empty properties, the overflow properties (after the first 100 in the
preview) show up as 'undefined x N' when they are not undefined.

Repro case:
var b = new Array(200);
b.fill(2);
console.log(b);

crbug.com/675259

Original issue's description:
> DevTools: merge array formatting logic
>
> This CL makes array formatting consistent and prepares
> RemoteObjectPreviewFormatter (ROPF) to introduce character cutoff logic.
> Today, array formatting is split between two files. The logic in
> ConsoleViewMessage has been folded into ROPF.js with all arrays showing gaps
> with 'undefined x n' as much as possible then falling back to 'key: value'.
>
> For background on character cutoff logic, see C1 in the console preview doc.
>
> BUG=666882
>
> Committed: https://crrev.com/50c41a1483a808a3394581c717a18cf00773877e
> Cr-Commit-Position: refs/heads/master@{#438294}

TBR=lushnikov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675259

Committed: https://crrev.com/631b841680800d7ea174cc898a4f0c5884111b91
Cr-Commit-Position: refs/heads/master@{#439286}
==========

[commit-bot: I haz the power, 2016-12-17 02:22:34]

Patchset 1 (id:??) landed as
https://crrev.com/631b841680800d7ea174cc898a4f0c5884111b91
Cr-Commit-Position: refs/heads/master@{#439286}