Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2586603002:
Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity (Closed)
|
Created:
4 years ago by Ken Rockot(use gerrit already) Modified:
4 years ago Reviewers:
CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity
BUG=671268
TBR=tedchoc@chromium.org
Committed: https://crrev.com/289f5bc28ed08151664f28e085ec6d2ed26cb3c6
Cr-Commit-Position: refs/heads/master@{#439231}
Patch Set 1 #
Messages
Total messages: 13 (8 generated)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity BUG=671268 ========== to ========== Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity BUG=671268 TBR=tedchoc@chromium.org ==========
The CQ bit was unchecked by rockot@chromium.org
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481930342170350, "parent_rev":
"965b52c4655835ffed0eb4f28c12ea06a1130f05", "commit_rev":
"079e74de424e0ab0aea62cd15a48043987ab4887"}
Message was sent while issue was closed.
Description was changed from ========== Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity BUG=671268 TBR=tedchoc@chromium.org ========== to ========== Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity BUG=671268 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2586603002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity BUG=671268 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2586603002 ========== to ========== Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity BUG=671268 TBR=tedchoc@chromium.org Committed: https://crrev.com/289f5bc28ed08151664f28e085ec6d2ed26cb3c6 Cr-Commit-Position: refs/heads/master@{#439231} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/289f5bc28ed08151664f28e085ec6d2ed26cb3c6 Cr-Commit-Position: refs/heads/master@{#439231}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2585723004/ by boliu@chromium.org. The reason for reverting is: Not sure how this passed cq. But.. E 73.899s Main Unrecognized error occurred. Traceback (most recent call last): File "/b/swarm_slave/w/irpT6Ugr/build/android/test_runner.py", line 879, in main return RunTestsCommand(args) File "/b/swarm_slave/w/irpT6Ugr/build/android/test_runner.py", line 665, in RunTestsCommand return RunTestsInPlatformMode(args) File "/b/swarm_slave/w/irpT6Ugr/build/android/test_runner.py", line 774, in RunTestsInPlatformMode raw_results = test_run.RunTests() File "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/local/device/local_device_test_run.py", line 65, in RunTests tests = self._GetTests() File "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/local/device/local_device_instrumentation_test_run.py", line 177, in _GetTests return self._test_instance.GetTests() File "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/instrumentation/instrumentation_test_instance.py", line 751, in GetTests self._excluded_annotations) File "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/instrumentation/instrumentation_test_instance.py", line 282, in FilterTests raise MissingSizeAnnotationError(GetTestName(t)) MissingSizeAnnotationError: org.chromium.chrome.browser.incognito.IncognitoNotificationServiceTest#testSingleRunningChromeTabbedActivity: Test method is missing required size annotation. Add one of: @LargeTest, @PerfTest, @Manual, @FlakyTest, @DisabledTest, @MediumTest, @Smoke, @SmallTest, @IntegrationTest, @EnormousTest.
Message was sent while issue was closed.
On 2016/12/17 02:22:11, boliu wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2585723004/ by mailto:boliu@chromium.org. > > The reason for reverting is: Not sure how this passed cq. But.. > > E 73.899s Main Unrecognized error occurred. > Traceback (most recent call last): > File "/b/swarm_slave/w/irpT6Ugr/build/android/test_runner.py", line 879, in > main > return RunTestsCommand(args) > File "/b/swarm_slave/w/irpT6Ugr/build/android/test_runner.py", line 665, in > RunTestsCommand > return RunTestsInPlatformMode(args) > File "/b/swarm_slave/w/irpT6Ugr/build/android/test_runner.py", line 774, in > RunTestsInPlatformMode > raw_results = test_run.RunTests() > File > "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/local/device/local_device_test_run.py", > line 65, in RunTests > tests = self._GetTests() > File > "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/local/device/local_device_instrumentation_test_run.py", > line 177, in _GetTests > return self._test_instance.GetTests() > File > "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/instrumentation/instrumentation_test_instance.py", > line 751, in GetTests > self._excluded_annotations) > File > "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/instrumentation/instrumentation_test_instance.py", > line 282, in FilterTests > raise MissingSizeAnnotationError(GetTestName(t)) > MissingSizeAnnotationError: > org.chromium.chrome.browser.incognito.IncognitoNotificationServiceTest#testSingleRunningChromeTabbedActivity: > Test method is missing required size annotation. Add one of: @LargeTest, > @PerfTest, @Manual, @FlakyTest, @DisabledTest, @MediumTest, @Smoke, @SmallTest, > @IntegrationTest, @EnormousTest. possibly crbug.com/675220 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
