[Findit] Adding build model for flake try jobs

[Findit] Adding build model for flake try jobs

BUG=672724
Review-Url: https://codereview.chromium.org/2586483003
Committed: https://chromium.googlesource.com/infra/infra/+/4e6e3b1b11056a76b7f7df13102c829f5309ea22

[lijeffrey, 2016-12-16 20:32:19]

Description was changed from

==========
[Findit] Adding build model for flake try jobs


[Findit] Adding build model for flake try job


[Findit] Adding build model for flake try job


[Findit] Adding build model for flake try job

BUG=
==========

to

==========
[Findit] Adding build model for flake try jobs

BUG=672724
==========

[lijeffrey, 2016-12-16 20:32:19]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, robertocn@chromium.org, stgao@chromium.org

[stgao, 2016-12-16 23:41:05]

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
File appengine/findit/model/base_try_job.py (right):

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
appengine/findit/model/base_try_job.py:1: # Copyright 2015 The Chromium Authors.
All rights reserved.
2016

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
appengine/findit/model/base_try_job.py:27: raise NotImplementedError('Get should
be implemented in the child class')
Why these two methods are needed in the base class?

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
File appengine/findit/model/flake/flake_try_job.py (right):

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
appengine/findit/model/flake/flake_try_job.py:15: flake_results =
ndb.JsonProperty(indexed=False, compressed=True)
How this will exactly look like?

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
appengine/findit/model/flake/flake_try_job.py:18: def
_CreateTryJobId(master_name, builder_name, build_number, step_name,
What's build number here? Why we don't need the revision we rerun the test at?

[stgao, 2016-12-16 23:55:54]

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
File appengine/findit/model/wf_try_job.py (right):

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
appengine/findit/model/wf_try_job.py:23: try_job_ids =
ndb.JsonProperty(indexed=False, compressed=True)
Do we still need this?

[lijeffrey, 2016-12-17 02:45:43]

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
File appengine/findit/model/base_try_job.py (right):

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
appengine/findit/model/base_try_job.py:1: # Copyright 2015 The Chromium Authors.
All rights reserved.
On 2016/12/16 23:41:05, stgao (slow on Monday) wrote:
> 2016

Done.

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
appengine/findit/model/base_try_job.py:27: raise NotImplementedError('Get should
be implemented in the child class')
On 2016/12/16 23:41:05, stgao (slow on Monday) wrote:
> Why these two methods are needed in the base class?

Removed

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
File appengine/findit/model/flake/flake_try_job.py (right):

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
appengine/findit/model/flake/flake_try_job.py:15: flake_results =
ndb.JsonProperty(indexed=False, compressed=True)
On 2016/12/16 23:41:05, stgao (slow on Monday) wrote:
> How this will exactly look like?

Done.

https://codereview.chromium.org/2586483003/diff/20001/appengine/findit/model/...
appengine/findit/model/flake/flake_try_job.py:18: def
_CreateTryJobId(master_name, builder_name, build_number, step_name,
On 2016/12/16 23:41:05, stgao (slow on Monday) wrote:
> What's build number here? Why we don't need the revision we rerun the test at?

Done.

[stgao, 2016-12-22 00:34:53]

lgtm % comments

https://codereview.chromium.org/2586483003/diff/40001/appengine/findit/model/...
File appengine/findit/model/wf_try_job.py (right):

https://codereview.chromium.org/2586483003/diff/40001/appengine/findit/model/...
appengine/findit/model/wf_try_job.py:28: compile_results =
ndb.JsonProperty(indexed=False, compressed=True)
Please add a TODO to merge the these two or three result fields into one, and
assign it to me.

Filing a bug would be appreciated.

https://codereview.chromium.org/2586483003/diff/40001/appengine/findit/model/...
appengine/findit/model/wf_try_job.py:43: try_job_ids =
ndb.JsonProperty(indexed=False, compressed=True)
Isn't this in the base_try_job.py ?

[lijeffrey, 2016-12-22 02:43:03]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-12-22 02:43:04]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2586483003/#ps120001
(title: "Fixing whitespace")

[commit-bot: I haz the power, 2016-12-22 02:43:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 02:52:07]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1482374583865920,
"parent_rev": "9599b0a81a599cb27ac7931dfe81b63d2cf0500a", "commit_rev":
"4e6e3b1b11056a76b7f7df13102c829f5309ea22"}

[commit-bot: I haz the power, 2016-12-22 02:52:10]

Description was changed from

==========
[Findit] Adding build model for flake try jobs

BUG=672724
==========

to

==========
[Findit] Adding build model for flake try jobs

BUG=672724

Review-Url: https://codereview.chromium.org/2586483003
Committed:
https://chromium.googlesource.com/infra/infra/+/4e6e3b1b11056a76b7f7df13102c8...
==========

[commit-bot: I haz the power, 2016-12-22 02:52:11]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/infra/infra/+/4e6e3b1b11056a76b7f7df13102c8...