Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2586483002: Use explicit WebString <-> string16 conversion methods in storage API files (Closed)

Created:
4 years ago by kinuko
Modified:
4 years ago
Reviewers:
jsbell
CC:
chromium-reviews, tzik, jam, nhiroki, blink-reviews-api_chromium.org, dglazkov+blink, darin-cc_chromium.org, cmumford, blink-reviews, jsbell+idb_chromium.org, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString <-> string16 conversion methods in storage API files As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) Also adds FilePathToWebString() utility method that does reverse of WebStringToFilePath. BUG=667131 Committed: https://crrev.com/6a43aaa91b9ce5fbbb1b4a499a15f0fba43cd79b Cr-Commit-Position: refs/heads/master@{#439296}

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -68 lines) Patch
M content/child/database_util.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/child/db_message_filter.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 5 chunks +16 lines, -19 lines 0 comments Download
M content/child/indexed_db/indexed_db_callbacks_impl.cc View 1 6 chunks +20 lines, -11 lines 0 comments Download
M content/child/indexed_db/indexed_db_database_callbacks_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_key_builders.cc View 1 5 chunks +15 lines, -8 lines 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M content/child/indexed_db/webidbfactory_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/web_database_observer_impl.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M content/child/webfileutilities_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/FilePathConversion.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/FilePathConversionTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/FilePathConversion.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebString.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
kinuko
Mind taking a look? Most changes are mechanical.
4 years ago (2016-12-16 15:52:12 UTC) #3
jsbell
lgtm
4 years ago (2016-12-16 17:21:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586483002/20001
4 years ago (2016-12-17 02:28:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-17 02:36:28 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-17 02:40:16 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a43aaa91b9ce5fbbb1b4a499a15f0fba43cd79b
Cr-Commit-Position: refs/heads/master@{#439296}

Powered by Google App Engine
This is Rietveld 408576698