Add CreateDataPropertyInLiteralFlags.

Add CreateDataPropertyInLiteralFlags.

Encode the PropertyAttribute and whether the function
names must be set as a flag instead of setting two registers.

BUG=v8:5624
Review-Url: https://codereview.chromium.org/2586463002
Cr-Commit-Position: refs/heads/master@{#41812}
Committed: https://chromium.googlesource.com/v8/v8/+/86eafdd4c0a7f3f184cf89a252e14547f5070ea4

[Franzi, 2016-12-16 13:43:08]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 13:43:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 13:58:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 13:58:06]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Franzi, 2016-12-16 14:01:21]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 14:01:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2016-12-16 14:13:45]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 14:13:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 14:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 14:37:44]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-12-16 16:48:49]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 16:48:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 17:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 17:17:39]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-12-19 09:19:44]

franzih@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Franzi, 2016-12-19 09:19:45]

PTAL

Thanks, 

Franzi

[Franzi, 2016-12-19 14:46:50]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 14:46:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 14:48:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 14:48:29]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18073)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18133)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30952)

[Franzi, 2016-12-19 14:58:50]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 14:58:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2016-12-19 15:15:35]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 15:15:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 15:45:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 15:45:19]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-12-19 15:47:35]

Very nice. LGTM % nits.

https://codereview.chromium.org/2586463002/diff/120001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/2586463002/diff/120001/src/globals.h#newcode1314
src/globals.h:1314: enum class DataPropertyInLiteralFlag {
Nit: Add a description for this.

https://codereview.chromium.org/2586463002/diff/120001/src/globals.h#newcode1315
src/globals.h:1315: kNone = 0,
Nit: kNoFlags

https://codereview.chromium.org/2586463002/diff/120001/src/globals.h#newcode1316
src/globals.h:1316: kDontEnum = 1,
Nit: 1 << 0 for consistency.

[Franzi, 2016-12-19 16:00:40]

The CQ bit was checked by franzih@chromium.org

[Franzi, 2016-12-19 16:00:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2586463002/#ps140001
(title: "Address review comments.")

[commit-bot: I haz the power, 2016-12-19 16:00:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 16:30:36]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1482163240819610,
"parent_rev": "1c763e004cae568eebb9d2eb5888f013292e8c76", "commit_rev":
"86eafdd4c0a7f3f184cf89a252e14547f5070ea4"}

[commit-bot: I haz the power, 2016-12-19 16:30:43]

Description was changed from

==========
Add CreateDataPropertyInLiteralFlags.

Encode the PropertyAttribute and whether the function
names must be set as a flag instead of setting two registers.

BUG=v8:5624
==========

to

==========
Add CreateDataPropertyInLiteralFlags.

Encode the PropertyAttribute and whether the function
names must be set as a flag instead of setting two registers.

BUG=v8:5624

Review-Url: https://codereview.chromium.org/2586463002
Cr-Commit-Position: refs/heads/master@{#41812}
Committed:
https://chromium.googlesource.com/v8/v8/+/86eafdd4c0a7f3f184cf89a252e14547f50...
==========

[commit-bot: I haz the power, 2016-12-19 16:30:45]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/86eafdd4c0a7f3f184cf89a252e14547f50...