Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2586413002: Remove Autofill's ContainsNonNullEntryForNonNullKey. (Closed)

Created:
4 years ago by Avi (use Gerrit)
Modified:
4 years ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Autofill's ContainsNonNullEntryForNonNullKey. Its last caller was removed in r306479. BUG=556939 Committed: https://crrev.com/beeae20314c0be11c05e181e94120ff12e320676 Cr-Commit-Position: refs/heads/master@{#439814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Avi (use Gerrit)
4 years ago (2016-12-19 22:42:11 UTC) #4
vabr (Chromium)
LGTM, thank you for the clean-up!
4 years ago (2016-12-20 07:20:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586413002/1
4 years ago (2016-12-20 15:58:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 16:03:35 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 16:05:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/beeae20314c0be11c05e181e94120ff12e320676
Cr-Commit-Position: refs/heads/master@{#439814}

Powered by Google App Engine
This is Rietveld 408576698