Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2586363002: [Mac] RTL aware drawing for the security bubble hover background (Closed)

Created:
4 years ago by lgrey
Modified:
4 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] RTL aware drawing for the bubble decoration hover background BUG=648557 Committed: https://crrev.com/8557f6fd655f9f0f62666721c7176d3d3c1e77f7 Cr-Commit-Position: refs/heads/master@{#439808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
lgrey
PTAL :)
4 years ago (2016-12-19 21:46:15 UTC) #7
Robert Sesek
LGTM
4 years ago (2016-12-19 23:21:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586363002/1
4 years ago (2016-12-20 15:27:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c7e7edefb984c7c8605e5ef22b3c997a6add5c88
4 years ago (2016-12-20 15:32:36 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 15:34:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8557f6fd655f9f0f62666721c7176d3d3c1e77f7
Cr-Commit-Position: refs/heads/master@{#439808}

Powered by Google App Engine
This is Rietveld 408576698