Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2586353002: [Chromecast][Clean-Up] Remove CastCdmProxy. (Closed)

Created:
4 years ago by slan
Modified:
4 years ago
Reviewers:
yucliu1, alokp
CC:
chromium-reviews, eme-reviews_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast][Clean-Up] Remove CastCdmProxy. Now that the "media" service is used on every Cast build, we no longer need this thread-hopping class. BUG=660736 Test: Cast compiles, no functionality changes Change-Id: I89639dfb874e1a3b46d63666b83f0227250e526b Committed: https://crrev.com/10f4f12110902b827554d592f9ba146b0b28ce35 Cr-Commit-Position: refs/heads/master@{#439684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -253 lines) Patch
M chromecast/media/cdm/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/media/cdm/cast_cdm_factory.cc View 2 chunks +0 lines, -11 lines 0 comments Download
D chromecast/media/cdm/cast_cdm_proxy.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chromecast/media/cdm/cast_cdm_proxy.cc View 1 chunk +0 lines, -167 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
slan
Overdue clean-up, PTAL
4 years ago (2016-12-19 18:53:43 UTC) #2
alokp
Defering to Yuchen. lgtm
4 years ago (2016-12-19 21:47:30 UTC) #8
yucliu1
On 2016/12/19 21:47:30, alokp wrote: > Defering to Yuchen. lgtm lgtm
4 years ago (2016-12-20 02:54:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586353002/1
4 years ago (2016-12-20 02:55:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 03:00:57 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-20 03:03:02 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10f4f12110902b827554d592f9ba146b0b28ce35
Cr-Commit-Position: refs/heads/master@{#439684}

Powered by Google App Engine
This is Rietveld 408576698