Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: ui/base/accelerators/accelerator_manager_delegate.h

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Add RegisterAccelerator. Use const auto& for vector iteration. Fix names/comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/accelerators/accelerator_manager_delegate.h
diff --git a/ui/base/accelerators/accelerator_manager_delegate.h b/ui/base/accelerators/accelerator_manager_delegate.h
index e3c6d9ccf6e53ebee773c721a1374ae0b03e18c0..f73cc9fa3129767755b1b39477339c821a1e3ac1 100644
--- a/ui/base/accelerators/accelerator_manager_delegate.h
+++ b/ui/base/accelerators/accelerator_manager_delegate.h
@@ -13,11 +13,15 @@ class Accelerator;
class UI_BASE_EXPORT AcceleratorManagerDelegate {
public:
- // Called the first time a target is registered for |accelerator|. This is
- // only called the first time a target is registered for a unique accelerator.
- // For example, if Register() is called twice with the same accelerator
- // this is called only for the first call.
- virtual void OnAcceleratorRegistered(const Accelerator& accelerator) = 0;
+ // Called when new accelerators are registered. This is only called with
+ // newly registered accelerators. For example, if Register() is
+ // called with A and B, then OnAcceleratorsRegistered() is called with A and
+ // B. If
sky 2017/01/30 17:13:31 Join this line and the next?
thanhph1 2017/01/30 17:45:12 Done.
+ // Register() is subsequently called with A and C, then
+ // OnAcceleratorsRegistered()
sky 2017/01/30 17:13:31 Join this line and the next?
thanhph1 2017/01/30 17:45:12 Done, thanks!
+ // is only called with C, as A was already registered.
+ virtual void OnAcceleratorsRegistered(
+ const std::vector<ui::Accelerator>& accelerators) = 0;
// Called when there no more targets are registered for |accelerator|.
virtual void OnAcceleratorUnregistered(const Accelerator& accelerator) = 0;

Powered by Google App Engine
This is Rietveld 408576698