Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: ui/base/accelerators/accelerator_manager_delegate.h

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Add RegisterAccelerator. Use const auto& for vector iteration. Fix names/comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_BASE_ACCELERATORS_ACCELERATOR_MANAGER_DELEGATE_H_ 5 #ifndef UI_BASE_ACCELERATORS_ACCELERATOR_MANAGER_DELEGATE_H_
6 #define UI_BASE_ACCELERATORS_ACCELERATOR_MANAGER_DELEGATE_H_ 6 #define UI_BASE_ACCELERATORS_ACCELERATOR_MANAGER_DELEGATE_H_
7 7
8 #include "ui/base/ui_base_export.h" 8 #include "ui/base/ui_base_export.h"
9 9
10 namespace ui { 10 namespace ui {
11 11
12 class Accelerator; 12 class Accelerator;
13 13
14 class UI_BASE_EXPORT AcceleratorManagerDelegate { 14 class UI_BASE_EXPORT AcceleratorManagerDelegate {
15 public: 15 public:
16 // Called the first time a target is registered for |accelerator|. This is 16 // Called when new accelerators are registered. This is only called with
17 // only called the first time a target is registered for a unique accelerator. 17 // newly registered accelerators. For example, if Register() is
18 // For example, if Register() is called twice with the same accelerator 18 // called with A and B, then OnAcceleratorsRegistered() is called with A and
19 // this is called only for the first call. 19 // B. If
sky 2017/01/30 17:13:31 Join this line and the next?
thanhph1 2017/01/30 17:45:12 Done.
20 virtual void OnAcceleratorRegistered(const Accelerator& accelerator) = 0; 20 // Register() is subsequently called with A and C, then
21 // OnAcceleratorsRegistered()
sky 2017/01/30 17:13:31 Join this line and the next?
thanhph1 2017/01/30 17:45:12 Done, thanks!
22 // is only called with C, as A was already registered.
23 virtual void OnAcceleratorsRegistered(
24 const std::vector<ui::Accelerator>& accelerators) = 0;
21 25
22 // Called when there no more targets are registered for |accelerator|. 26 // Called when there no more targets are registered for |accelerator|.
23 virtual void OnAcceleratorUnregistered(const Accelerator& accelerator) = 0; 27 virtual void OnAcceleratorUnregistered(const Accelerator& accelerator) = 0;
24 28
25 protected: 29 protected:
26 virtual ~AcceleratorManagerDelegate() {} 30 virtual ~AcceleratorManagerDelegate() {}
27 }; 31 };
28 32
29 } // namespace ui 33 } // namespace ui
30 34
31 #endif // UI_BASE_ACCELERATORS_ACCELERATOR_MANAGER_DELEGATE_H_ 35 #endif // UI_BASE_ACCELERATORS_ACCELERATOR_MANAGER_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698