build/get_landmines.py - Issue 258633003: Graphical version of the run_binary_size_analysis tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/get_landmines.py

Issue 258633003: Graphical version of the run_binary_size_analysis tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made the code fully pylint clean. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/get_landmines.py

diff --git a/build/get_landmines.py b/build/get_landmines.py

index ab71608b925e7779d321b1156cfa6271df92a9c4..2fdb14f354a4a21b329e0b5e8c977cc8f3932219 100755

--- a/build/get_landmines.py

+++ b/build/get_landmines.py

@@ -30,7 +30,7 @@ def print_landmines(target):

builder() == 'ninja'):

print 'Need to clobber winja goma due to backend cwd cache fix.'

if platform() == 'android':

- print 'Clobber: Autogen java file needs to be removed (issue 159173002)'

+ print 'Clobber: build_size.jar needs to be deleted (issue 258633003)'

if platform() == 'win' and builder() == 'ninja':

print 'Compile on cc_unittests fails due to symbols removed in r185063.'

if platform() == 'linux' and builder() == 'ninja':

« no previous file with comments | « build/android/pylib/symbols/elf_symbolizer.py ('k') | tools/binary_size/binary_size.gyp » ('j') | no next file with comments »