Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: build/get_landmines.py

Issue 258633003: Graphical version of the run_binary_size_analysis tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made the code fully pylint clean. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/pylib/symbols/elf_symbolizer.py ('k') | tools/binary_size/binary_size.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file emits the list of reasons why a particular build needs to be clobbered 7 This file emits the list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 """ 9 """
10 10
(...skipping 12 matching lines...) Expand all
23 23
24 def print_landmines(target): 24 def print_landmines(target):
25 """ 25 """
26 ALL LANDMINES ARE EMITTED FROM HERE. 26 ALL LANDMINES ARE EMITTED FROM HERE.
27 target can be one of {'Release', 'Debug', 'Debug_x64', 'Release_x64'}. 27 target can be one of {'Release', 'Debug', 'Debug_x64', 'Release_x64'}.
28 """ 28 """
29 if (distributor() == 'goma' and platform() == 'win32' and 29 if (distributor() == 'goma' and platform() == 'win32' and
30 builder() == 'ninja'): 30 builder() == 'ninja'):
31 print 'Need to clobber winja goma due to backend cwd cache fix.' 31 print 'Need to clobber winja goma due to backend cwd cache fix.'
32 if platform() == 'android': 32 if platform() == 'android':
33 print 'Clobber: Autogen java file needs to be removed (issue 159173002)' 33 print 'Clobber: build_size.jar needs to be deleted (issue 258633003)'
34 if platform() == 'win' and builder() == 'ninja': 34 if platform() == 'win' and builder() == 'ninja':
35 print 'Compile on cc_unittests fails due to symbols removed in r185063.' 35 print 'Compile on cc_unittests fails due to symbols removed in r185063.'
36 if platform() == 'linux' and builder() == 'ninja': 36 if platform() == 'linux' and builder() == 'ninja':
37 print 'Builders switching from make to ninja will clobber on this.' 37 print 'Builders switching from make to ninja will clobber on this.'
38 if platform() == 'mac': 38 if platform() == 'mac':
39 print 'Switching from bundle to unbundled dylib (issue 14743002).' 39 print 'Switching from bundle to unbundled dylib (issue 14743002).'
40 if platform() in ('win', 'mac'): 40 if platform() in ('win', 'mac'):
41 print ('Improper dependency for create_nmf.py broke in r240802, ' 41 print ('Improper dependency for create_nmf.py broke in r240802, '
42 'fixed in r240860.') 42 'fixed in r240860.')
43 if (platform() == 'win' and builder() == 'ninja' and 43 if (platform() == 'win' and builder() == 'ninja' and
(...skipping 18 matching lines...) Expand all
62 62
63 if args: 63 if args:
64 parser.error('Unknown arguments %s' % args) 64 parser.error('Unknown arguments %s' % args)
65 65
66 print_landmines(options.target) 66 print_landmines(options.target)
67 return 0 67 return 0
68 68
69 69
70 if __name__ == '__main__': 70 if __name__ == '__main__':
71 sys.exit(main()) 71 sys.exit(main())
OLDNEW
« no previous file with comments | « build/android/pylib/symbols/elf_symbolizer.py ('k') | tools/binary_size/binary_size.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698