Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2586303002: [Extensions Bindings] Pull out test resources (Closed)

Created:
4 years ago by Devlin
Modified:
4 years ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Pull out test resources A string-backed source map and ability to use safe builtins in testing are going to be necessary for future API binding unit tests, in addition to the module system tests that use them already. Pull them out into separate files to allow reuse. BUG=653596 Committed: https://crrev.com/892cc67f12a599659ebd10c091ad3c1811e857ef Cr-Commit-Position: refs/heads/master@{#439530}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -54 lines) Patch
M extensions/renderer/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/renderer/module_system_test.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system_test.cc View 3 chunks +3 lines, -53 lines 0 comments Download
A extensions/renderer/string_source_map.h View 1 chunk +39 lines, -0 lines 0 comments Download
A extensions/renderer/string_source_map.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A extensions/renderer/test_v8_extension_configuration.h View 1 1 chunk +39 lines, -0 lines 0 comments Download
A extensions/renderer/test_v8_extension_configuration.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
Hey lazyboy@, jbroman's out today so I figured I may as well pull these mechanical ...
4 years ago (2016-12-19 18:30:27 UTC) #6
lazyboy
lgtm
4 years ago (2016-12-19 19:19:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586303002/20001
4 years ago (2016-12-19 19:55:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 20:00:49 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 20:05:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/892cc67f12a599659ebd10c091ad3c1811e857ef
Cr-Commit-Position: refs/heads/master@{#439530}

Powered by Google App Engine
This is Rietveld 408576698