Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2586253004: Revert of Optimize KURL protocols (Closed)

Created:
4 years ago by Charlie Harrison
Modified:
4 years ago
Reviewers:
esprehn
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Optimize KURL protocols (patchset #9 id:160001 of https://codereview.chromium.org/2463703002/ ) Reason for revert: Causing DCHECK flakes. crbug.com/674388 Original issue's description: > Optimize KURL protocols > > This patch optimizes KURL::protocol and KURL::protocolIs by keeping > an AtomicString m_protocol on KURL. This reduces string allocations > throughout the code using KURL::protocol(). > > This also fixes an inconsistency with KURL::protocolIs that will return > true for invalid URLs. > > BUG=348655 > > Committed: https://crrev.com/775abc2d7c903f191f7b24f8b299ebabbea3f624 > Cr-Commit-Position: refs/heads/master@{#438197} TBR=esprehn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=348655, 674388 Committed: https://crrev.com/8885747f52b034575336f97e354fa8043f6c1b9f Cr-Commit-Position: refs/heads/master@{#439722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -80 lines) Patch
M third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURL.h View 1 chunk +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURL.cpp View 14 chunks +64 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURLTest.cpp View 2 chunks +20 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringStatics.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Charlie Harrison
Created Revert of Optimize KURL protocols
4 years ago (2016-12-20 04:16:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586253004/1
4 years ago (2016-12-20 04:16:51 UTC) #4
Charlie Harrison
4 years ago (2016-12-20 04:16:55 UTC) #5
Charlie Harrison
TBR esprehn for revert
4 years ago (2016-12-20 04:17:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 06:03:34 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 06:08:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8885747f52b034575336f97e354fa8043f6c1b9f
Cr-Commit-Position: refs/heads/master@{#439722}

Powered by Google App Engine
This is Rietveld 408576698