Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 2586223002: Unflake media/video-poster-after-loadedmetadata.html (Closed)

Created:
4 years ago by mlamouri (slow - plz ping)
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unflake media/video-poster-after-loadedmetadata.html Instead of having a 2 seconds timeout, using a combination of setTimeout of 0 and requestAnimationFrame. BUG=513398 R=zqzhang@chromium.org Committed: https://crrev.com/6bd0dace1e4df7a5a84ae5818418306bef9e30db Cr-Commit-Position: refs/heads/master@{#439468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-poster-after-loadedmetadata.html View 1 chunk +7 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mlamouri (slow - plz ping)
4 years ago (2016-12-19 12:12:31 UTC) #3
Zhiqiang Zhang (Slow)
lgtm Hope the bots are happy :)
4 years ago (2016-12-19 13:18:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586223002/1
4 years ago (2016-12-19 13:57:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f9456b0eee45a811e834ecaee8c4e4eb0654fe7e
4 years ago (2016-12-19 14:02:23 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-19 14:03:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bd0dace1e4df7a5a84ae5818418306bef9e30db
Cr-Commit-Position: refs/heads/master@{#439468}

Powered by Google App Engine
This is Rietveld 408576698